Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(converters): add DivisionMathConverter and update bindings #32

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

realybin
Copy link
Member

  • Introduced DivisionMathConverter for division operations in data binding.
  • Updated MainWindow.xaml, PageNavigationView.xaml, and ToolBarView.xaml to use the new BoolToVisibilityConverter.
  • Replaced old visibility converter references to ensure consistency across the application.

- Introduced `DivisionMathConverter` for division operations in data binding.
- Updated `MainWindow.xaml`, `PageNavigationView.xaml`, and `ToolBarView.xaml` to use the new `BoolToVisibilityConverter`.
- Replaced old visibility converter references to ensure consistency across the application.
@realybin realybin merged commit c3145b4 into SketchNow:main Jan 22, 2025
3 checks passed
@realybin realybin deleted the feat/addconverters branch January 22, 2025 16:46
Copy link

Summary - Code Coverage

Summary
Generated on: 1/22/2025 - 4:48:15 PM
Coverage date: 1/22/2025 - 4:48:12 PM
Parser: Cobertura
Assemblies: 1
Classes: 18
Files: 27
Line coverage: 27.9% (114 of 408)
Covered lines: 114
Uncovered lines: 294
Coverable lines: 408
Total lines: 2034
Branch coverage: 20.2% (15 of 74)
Covered branches: 15
Total branches: 74
Method coverage: Feature is only available for sponsors
Tag: 109_12912990000

Coverage

SketchNow - 27.9%
Name Line Branch
SketchNow 27.9% 20.2%
SketchNow.App 0% 0%
SketchNow.Controls.CustomInkCanvas 0%
SketchNow.Controls.IconWithText 0% 0%
SketchNow.Converters.ColorToBrushConverter 0% 0%
SketchNow.Converters.DivisionMathConverter 0% 0%
SketchNow.Converters.EnumToIndexConverter 0% 0%
SketchNow.Input.StylusPlugIns.CustomStylusPlugin 0%
SketchNow.Models.CanvasPage 32.3% 25%
SketchNow.Models.CanvasPages 35.2%
SketchNow.Models.CursorNotFoundException 0%
SketchNow.Models.CustomCursors 100% 50%
SketchNow.Properties.Resource 0% 0%
SketchNow.Properties.Settings 45.4%
SketchNow.ViewModels.MainWindowViewModel 62% 40%
SketchNow.Views.MainWindow 0% 0%
SketchNow.Views.PageNavigationView 0% 0%
SketchNow.Views.SettingsView 0% 0%
SketchNow.Views.ToolBarView 0% 0%

realybin added a commit that referenced this pull request Feb 19, 2025
- Introduced `DivisionMathConverter` for division operations in data binding.
- Updated `MainWindow.xaml`, `PageNavigationView.xaml`, and `ToolBarView.xaml` to use the new `BoolToVisibilityConverter`.
- Replaced old visibility converter references to ensure consistency across the application.
realybin added a commit that referenced this pull request Feb 19, 2025
- Introduced `DivisionMathConverter` for division operations in data binding.
- Updated `MainWindow.xaml`, `PageNavigationView.xaml`, and `ToolBarView.xaml` to use the new `BoolToVisibilityConverter`.
- Replaced old visibility converter references to ensure consistency across the application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant