Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAA - Feature/multiple locations #1980

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

dashton82
Copy link
Contributor

No description provided.

@dashton82 dashton82 requested a review from a team as a code owner February 24, 2025 22:19
killij and others added 9 commits February 25, 2025 13:12
- Changed `postedInLastNumberOfDays` from `7` to `8` in the request URL.
- Added `OtherAddresses`, `EmploymentLocationInformation`, and
  `EmploymentLocationOption` to `GetSavedSearchVacanciesQueryResult`.
- Modified `Address` property source in `GetSavedSearchVacanciesQueryResult`.
- Replaced `VacancyAddress` with `Address` in `GetVacanciesResponse`.
- Removed `Address` and `VacancyAddress` classes for consolidation.

Changes made by Balaji Jambulingam
- Added optional parameter `bool cityNamesOnly` to `GetVacancyWorkLocation`.
- Updated method implementation to return city names or full addresses.
- Modified calls to `GetVacancyWorkLocation` in tests and handlers.
- Added new test cases for multiple locations and city name retrieval.
- Updated `IVacancyService` interface and `VacancyService` implementation.

Changes made by Balaji Jambulingam
- Change `postedInLastNumberOfDays` from 8 to 7.
- Update `GetUrl` property in `GetVacanciesRequest` class.
- Modify corresponding test in `WhenBuildingGetVacanciesRequest.cs`.
- Ensure consistency between implementation and test URL formats.
- Reflect updated vacancy query logic in both files.

Changes made by Balaji Jambulingam
…-on-view-Vacancy-page-for-multiple-locations

FAI-2334 Add geo-coords to Vacancy map view for multiple locations
…ancies-Manage-for-Multiple-Locations

FAI-2234 Add support for Multiple Locations
…ail_Notifications

FAI-2265 hot fix email notifications
Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-EpaoRegister'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-PublicSectorReporting'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-ApimDeveloper'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-ApprenticeFeedback'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-ApprenticeCommitments'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-EmployerIncentives'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-ApprenticePortal'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-AparRegister'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-FindAnApprenticeship'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-Forecasting'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-LevyTransferMatching'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-Reservations'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-RoatpCourseManagement'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-VacanciesManage'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-EmployerFinance'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-EmployerAccounts'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-TrackProgress'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-TrackProgressInternal'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-Apprenticeships'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-RoatpProviderModeration'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-EarlyConnect'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-EmployerFeedback'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-EmployerProfiles'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-EmployerAan'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-FindApprenticeshipJobs'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-EmployerRequestApprenticeTraining'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-ProviderRequestApprenticeTraining'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-ProviderFeedback'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-ReferenceDataJobs'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-ApprenticeApp'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants