Fix concurrent do-while instances only running do section once
#8263
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnderscoreTud
requested review from
Burbulinis and
cheeezburga
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
UnderscoreTud
added
the
bug
sovdeeth
requested changes
Oct 30, 2025
I didn't know how to do tests for this since iirc you can't have delays in tests |
|
Just have a function with a do while, call the function twice |
APickledWalrus
approved these changes
Oct 30, 2025
skriptlang-automation
bot
removed
the
needs reviews
That won't properly test it, because without a delay the second loop will only run after the first function call has finished execution. As seen here: function test(id: text):
do while {_a} < 20:
broadcast {_id}
add 1 to {_a}
on load:
test("1")
test("2") |
|
Yeah but can't you have the delay exist but not rely on it finishing? Eg And just ensure the {} = number of times func is called |
sovdeeth
approved these changes
Nov 2, 2025
skriptlang-automation
bot
added
the
patch-ready
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.13 Releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If two or more
do-whilecalls of the same instance happen at the same time, thedosection only works properly for the first one.Solution
Use a set to track which events have run the
dosection instead of a single boolean variableTesting Completed
Manual testing
Supporting Information
N/A
Completes: #8262
Related: none