Move end of http request span to correct location. (#131)

Co-authored-by: zhangsihao <[email protected]>
SkyAPM · Sep 24, 2020 · c0e3fa0 · c0e3fa0
1 parent 3b13028
commit c0e3fa0
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/modules/nodejs-agent/lib/plugins/http/http.js b/modules/nodejs-agent/lib/plugins/http/http.js
@@ -109,7 +109,11 @@ module.exports = function(httpModule, instrumentation, contextManager) {
             span.component(componentDefine.Components.HTTP);
             span.spanLayer(layerDefine.Layers.HTTP);
             let result = original.apply(this, arguments);
-            contextManager.finishSpan(span);
+            result.once("response", function(res) {
+              res.once("end", function() {
+                contextManager.finishSpan(span);
+              });
+            });
             return result;
         };
     }