-
Couldn't load subscription status.
- Fork 18
Modernize workflows #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize workflows #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
|
ci of c++11 is not supported. But I think maybe you can disable it first. And create an issue for that. We can see whether we can fix it or just abandon c++11 in our new version. |
|
I believe it is better to drop support for version before c++17 as long as dependencies like protobuf require c++17, see |
|
I am OK to that. We won't add too much new features to cpp2sky. So, I think it's fine to support only c++17 in our new version. who won't the old version support still could use our old version. |
|
I have removed '-Werror' so it doesn't fail on warnings. |
|
Following https://stackoverflow.com/a/39194946 recommendation |
|
@mmorel-35 sorry for the delay. There is no pr-reminder there Orz. |
Signed-off-by: Matthieu MOREL <[email protected]>
|
@wbpcode , |
|
CI still not happy. |
Description
Ubuntu-20.04 is not supported by github anymore.
actions/checkout@v3 is also not documented in the README
Also uses actions/checkouts instead of git clones, will reduce the space taken as the reference is precised with only one commit being checked out.
I also used stepsecurity to define permissions appropriately with commit sha
See