[PAN-3132] Fix bpk nudger for subtitle long case (#2014)

* change overflow and maxline style for nudger

* Updated snapshots

* remove unuse line since default values and add more line case snapshot

* add BpkNudgerTest long subtitle case

* Updated snapshots

* Empty commit

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

app/src/main/java/net/skyscanner/backpack/demo/compose/NudgerStory.kt

@@ -72,6 +72,11 @@ fun NudgerStory(modifier: Modifier = Modifier) {
             modifier = Modifier.fillMaxWidth(),
         )
 
+        NudgerRowExample(
+            modifier = Modifier.fillMaxWidth(),
+            subtitle = stringResource(R.string.generic_subtitle_long_case),
+        )
+
         NudgerRowExample(
             modifier = Modifier.fillMaxWidth(),
             title = stringResource(R.string.generic_with_leading_icon),

app/src/main/res/values/strings.xml

@@ -362,6 +362,7 @@
 
     <string name="generic_title">Title</string>
     <string name="generic_subtitle">Subtitle</string>
+    <string name="generic_subtitle_long_case">Subtitle is an example of long text that can be wrapped</string>
 
     <string name="inset_banner_title">Title</string>
     <string name="inset_banner_sub_headline">SubHeadline</string>

app/src/test/java/net/skyscanner/backpack/compose/nudger/BpkNudgerTest.kt

@@ -18,11 +18,13 @@
 
 package net.skyscanner.backpack.compose.nudger
 
+import androidx.compose.ui.res.stringResource
 import net.skyscanner.backpack.compose.BpkSnapshotTest
 import net.skyscanner.backpack.BpkTestVariant
 import net.skyscanner.backpack.compose.icon.BpkIcon
 import net.skyscanner.backpack.compose.tokens.Account
 import net.skyscanner.backpack.Variants
+import net.skyscanner.backpack.demo.R
 import net.skyscanner.backpack.demo.compose.NudgerExample
 import net.skyscanner.backpack.demo.compose.NudgerRowExample
 import net.skyscanner.backpack.demo.compose.NudgerStoryAvg
@@ -88,6 +90,12 @@ class BpkNudgerTest : BpkSnapshotTest() {
         NudgerRowExample(subtitle = null)
     }
 
+    @Test
+    @Variants(BpkTestVariant.Default)
+    fun withLongSubtitle() = snap {
+        NudgerRowExample(subtitle = stringResource(R.string.generic_subtitle_long_case))
+    }
+
     @Test
     @Variants(BpkTestVariant.Default)
     fun withNoIcon() = snap {

backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/nudger/BpkNudger.kt

@@ -160,8 +160,6 @@ fun BpkNudger(
                         text = subtitle,
                         style = BpkTheme.typography.bodyDefault,
                         color = BpkTheme.colors.textSecondary,
-                        maxLines = 1,
-                        overflow = TextOverflow.Ellipsis,
                         modifier = Modifier.invisibleSemantic(),
                     )
                 }