This repository was archived by the owner on Mar 1, 2024. It is now read-only.
model experimentation component#87
Open
wintonzheng wants to merge 2 commits into
Open
Conversation
wintonzheng
commented
Oct 17, 2023
wintonzheng
commented
Contributor
- Does this PR have impact on local development experience? If yes, make sure you have a plan and add the documentations to address issues that come with the change
- bump version
- make a release
- publish to pypi service
wintonzheng
force-pushed
the
model_experimentation_component
branch
from
859be9c to
f59e194
Compare
wintonzheng
commented
Oct 27, 2023
| self.get_entity_id(input), | ||
| ) | ||
| # TODO: validation | ||
| if treatment is None: |
Contributor
Author
There was a problem hiding this comment.
question: how shall we handle the None use case?
wintonzheng
force-pushed
the
model_experimentation_component
branch
2 times, most recently
from
e72a34a to
40fcbc2
Compare
wintonzheng
force-pushed
the
model_experimentation_component
branch
from
40fcbc2 to
59e2e71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.