-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drift diffusion formulation #203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessicaRehak
added
enhancement
Addition of features to BART.
major
Involves multiple classes across multiple top level namespaces.
labels
Jan 5, 2021
Codecov Report
@@ Coverage Diff @@
## dev #203 +/- ##
==========================================
+ Coverage 98.49% 98.53% +0.03%
==========================================
Files 190 200 +10
Lines 3722 3822 +100
==========================================
+ Hits 3666 3766 +100
Misses 56 56
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Addition of features to BART.
major
Involves multiple classes across multiple top level namespaces.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds classes for the calculation of the drift-diffusion term, as well as the drift-diffusion form of the diffusion equation. Includes a major refactor to
FixedUpdater
that will be applied (in the future) to the other updaters. Now, updaters populate a vector of functions that are automatically called. Building a new updater is as easy as populating the vector and the base class handles the rest.First step to accomplish #5