Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drift diffusion formulation #203

Merged
merged 23 commits into from
Jan 5, 2021

Conversation

JessicaRehak
Copy link
Collaborator

This update adds classes for the calculation of the drift-diffusion term, as well as the drift-diffusion form of the diffusion equation. Includes a major refactor to FixedUpdater that will be applied (in the future) to the other updaters. Now, updaters populate a vector of functions that are automatically called. Building a new updater is as easy as populating the vector and the base class handles the rest.

First step to accomplish #5

@JessicaRehak JessicaRehak added enhancement Addition of features to BART. major Involves multiple classes across multiple top level namespaces. labels Jan 5, 2021
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #203 (070fa9e) into dev (79b554e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #203      +/-   ##
==========================================
+ Coverage   98.49%   98.53%   +0.03%     
==========================================
  Files         190      200      +10     
  Lines        3722     3822     +100     
==========================================
+ Hits         3666     3766     +100     
  Misses         56       56              
Impacted Files Coverage Δ
src/domain/finite_element/finite_element.h 100.00% <ø> (ø)
src/domain/finite_element/finite_element_i.h 100.00% <ø> (ø)
src/formulation/updater/diffusion_updater.hpp 100.00% <ø> (ø)
src/framework/builder/framework_builder.cpp 95.72% <ø> (ø)
...ft_diffusion/drift_diffusion_vector_calculator.cpp 100.00% <100.00%> (ø)
src/domain/finite_element/finite_element.cc 100.00% <100.00%> (ø)
src/formulation/scalar/drift_diffusion.cpp 100.00% <100.00%> (ø)
src/formulation/scalar/drift_diffusion.hpp 100.00% <100.00%> (ø)
src/formulation/scalar/drift_diffusion_i.hpp 100.00% <100.00%> (ø)
src/formulation/updater/diffusion_updater.cpp 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b554e...070fa9e. Read the comment docs.

@JessicaRehak JessicaRehak merged commit 58287b4 into SlaybaughLab:dev Jan 5, 2021
@JessicaRehak JessicaRehak deleted the drift_diffusion branch January 5, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Addition of features to BART. major Involves multiple classes across multiple top level namespaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant