Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Error page when connection lost + Open logs folder btn #1340

Merged
merged 8 commits into from
Mar 11, 2025

Conversation

loucass003
Copy link
Member

@loucass003 loucass003 commented Mar 10, 2025

image

@github-actions github-actions bot added Area: GUI Related to the GUI Area: Translation Improvements or additions to translations labels Mar 10, 2025
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small note that the "Open the logs folder" button won't work at all on Android right now. There's not really anything we can do about that for now though.

@ButterscotchV
Copy link
Member

Actually, it's also worth considering that a lot of the time, the server won't connect via websocket at all, maybe there could be a timeout on the loading page? At least to indicate that nothing is happening, as otherwise people will sit on that page for hours.

@loucass003 loucass003 merged commit e7b29b1 into main Mar 11, 2025
13 checks passed
@loucass003 loucass003 deleted the llelievr/connection-lost-page branch March 11, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI Area: Translation Improvements or additions to translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants