Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual height not submitting form value #1342

Merged
merged 5 commits into from
Mar 11, 2025

Conversation

ButterscotchV
Copy link
Member

It seems like we forgot to actually submit the form correctly. Changed to actually consume the form value.

@ButterscotchV ButterscotchV added Type: Bug Something isn't working Priority: High Important feature or blocks something important Area: GUI Related to the GUI labels Mar 10, 2025
nextStep();
}}
>
<Button variant="primary" onClick={handleSubmit(onSubmit)}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can look at WifiCredsPage for an example

@loucass003 loucass003 merged commit 49bcc86 into SlimeVR:main Mar 11, 2025
13 checks passed
@ButterscotchV ButterscotchV deleted the manual-height-fix branch March 12, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI Priority: High Important feature or blocks something important Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants