Skip to content

WIP Investigating Build assume problem #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jantje wants to merge 6 commits into
base: master
Choose a base branch
from
Open

WIP Investigating Build assume problem #1734

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
805a03e
Revert "pde plugin is needed for the builders setings"
Nov 17, 2025
c32e659
Revert "Revert "pde plugin is needed for the builders setings""
Nov 17, 2025
63c13ec
Revert "Revert "Revert "pde plugin is needed for the builders setings"""
Nov 17, 2025
cf62825
only depend on pde (exclude pde.ui)
Nov 17, 2025
b6e2ce1
Now add the pde.ui plugin (I expect this to break the build)
Nov 17, 2025
6500a5a
add if(){return;} before assumeFalse (for testing)
Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...eber.autoBuild.test/src/io/sloeber/autoBuild/regression/AutoBuildCreateBasicProjects.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ void testInternaltBuilderRoot(String inProjectName, String extensionPointID, Str
void testMakeBuilderRoot(String inProjectName, String extensionPointID, String extensionID, String projectTypeID,
String natureID, ICodeProvider codeProvider, IBuildTools buildTools) throws Exception {
if (doTestMakeBuilder) {
if(buildTools.getProviderID().equals("io.sloeber.autoBuild.Path.BuildToolProvider")) {
return;
}
Assumptions.assumeFalse(buildTools.getProviderID().equals("io.sloeber.autoBuild.Path.BuildToolProvider"),"Ignoring as make is not assumed on the path") ;
String projectName = "make_" + inProjectName;
if (projectName.length() > 40) {
Expand Down
Loading