CHAD 12650 Z-Wave: Update base thermostat driver to use dynamic numeric constraints for heating/cooling setpoints #1344
Conversation
This file is intended to contain code for dynamically retrieving setpoint constraints from zwave thermostats. The initial contents are copied from a zigbee bulb color bounds script with a similar purpose.
Do not explicitly use scale and precision. Rely on existing conversion utilities behind the scenes.
and fix an issue identified by this new test
They are not guaranteed to be in celsius
To account for the case a different controller on the network inquires about an unsupported setpoint
|
|
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 825a7e4 |
| @@ -37,6 +48,10 @@ local function device_added(driver, device) | |||
| device:is_cc_supported(cc.THERMOSTAT_FAN_MODE) then | |||
| device:send(ThermostatFanMode:SupportedGet({})) | |||
| end | |||
| if device_supports_thermostat_setpoint(device) then | |||
| device:send(ThermostatSetpointV3:CapabilitiesGet({setpoint_type = ThermostatSetpoint.setpoint_type.HEATING_1})) | |||
| device:send(ThermostatSetpointV3:CapabilitiesGet({setpoint_type = ThermostatSetpoint.setpoint_type.COOLING_1})) | |||
There was a problem hiding this comment.
Just curious why device_supports_thermostat_setpoint returns true if one or the other of the heating and cooling setpoint capabilities is supported, but here we are getting both. Would it make sense to only get what is supported?
There was a problem hiding this comment.
That is a good point. We do have some heat-only thermostats.
There was a problem hiding this comment.
Thanks for pointing out, I didn't think of that case. I adjusted this to be two conditions: Check for support for each heating and cooling setpoints independently before sending the request for the corresponding bounds.
Check the heating and cooling setpoint capabilities independently before sending each check instead of sending requests for both if either is supported. Some thermostats may support only one of the two.
Okay, yes it is my intention to test with a real device. I'm working on getting access to one. |
Uses Z-Wave
ThermostatSetpoint:CapabilitiesGetto request the thermostat setpoints for heating and cooling on initialization.