Skip to content

Support additional Room AC configurations #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: room-air-conditioner-cooling-only-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: room-air-conditioner-cooling-only
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: thermostatOperatingState
version: 1
config:
values:
- key: "thermostatOperatingState.value"
enabledValues:
- idle
- cooling
- heating
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: room-air-conditioner-fan-cooling-only-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: room-air-conditioner-fan-cooling
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: thermostatOperatingState
version: 1
config:
values:
- key: "thermostatOperatingState.value"
enabledValues:
- idle
- cooling
- heating
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: room-air-conditioner-fan-heating-only-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: room-air-conditioner-fan-heating-only
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: thermostatOperatingState
version: 1
config:
values:
- key: "thermostatOperatingState.value"
enabledValues:
- idle
- cooling
- heating
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: room-air-conditioner-fan-wind-heating-cooling-only-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: windMode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: room-air-conditioner-fan-wind-cooling-only
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: thermostatOperatingState
version: 1
config:
values:
- key: "thermostatOperatingState.value"
enabledValues:
- idle
- cooling
- heating
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: windMode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: room-air-conditioner-fan-wind-heating-cooling-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: windMode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: room-air-conditioner-fan-wind-heating-only-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: windMode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: room-air-conditioner-fan-wind-heating-only
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: thermostatOperatingState
version: 1
config:
values:
- key: "thermostatOperatingState.value"
enabledValues:
- idle
- cooling
- heating
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: windMode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: room-air-conditioner-heating-cooling-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: room-air-conditioner-heating-only-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: room-air-conditioner-heating-only
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: thermostatOperatingState
version: 1
config:
values:
- key: "thermostatOperatingState.value"
enabledValues:
- idle
- cooling
- heating
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: room-air-conditioner-humidity-cooling-only-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: relativeHumidityMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: room-air-conditioner-humidity-cooling-only
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: relativeHumidityMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: thermostatOperatingState
version: 1
config:
values:
- key: "thermostatOperatingState.value"
enabledValues:
- idle
- cooling
- heating
- id: airConditionerFanMode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner

Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: room-air-conditioner-humidity-fan-cooling-only-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: relativeHumidityMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: room-air-conditioner-humidity-fan-cooling-only
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: relativeHumidityMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: thermostatOperatingState
version: 1
config:
values:
- key: "thermostatOperatingState.value"
enabledValues:
- idle
- cooling
- heating
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: room-air-conditioner-humidity-fan-heating-cooling-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: relativeHumidityMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: room-air-conditioner-humidity-fan-heating-only-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: relativeHumidityMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: room-air-conditioner-humidity-fan-heating-only
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: relativeHumidityMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: thermostatOperatingState
version: 1
config:
values:
- key: "thermostatOperatingState.value"
enabledValues:
- idle
- cooling
- heating
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: room-air-conditioner-humidity-heating-cooling-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: relativeHumidityMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: room-air-conditioner-humidity-heating-only-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: relativeHumidityMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: room-air-conditioner-humidity-heating-only
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: relativeHumidityMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: thermostatOperatingState
version: 1
config:
values:
- key: "thermostatOperatingState.value"
enabledValues:
- idle
- cooling
- heating
- id: airConditionerFanMode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner

Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: room-air-conditioner-nostate
components:
- id: main
capabilities:
- id: switch
version: 1
- id: temperatureMeasurement
version: 1
- id: relativeHumidityMeasurement
version: 1
- id: thermostatMode
version: 1
- id: thermostatHeatingSetpoint
version: 1
- id: thermostatCoolingSetpoint
version: 1
- id: airConditionerFanMode
version: 1
- id: fanSpeedPercent
version: 1
- id: windMode
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: AirConditioner
8 changes: 5 additions & 3 deletions drivers/SmartThings/matter-thermostat/src/init.lua
Original file line number Diff line number Diff line change
@@ -677,16 +677,18 @@ local function match_profile(driver, device)
local thermostat_modes = create_thermostat_modes_profile(device)
if thermostat_modes == "" then
profile_name = profile_name .. "-heating-cooling"
else
device.log.warn_with({hub_logs=true}, "Device does not support both heating and cooling. No matching profile")
elseif thermostat_modes == "No Heating nor Cooling Support" then
device.log.warn_with({hub_logs=true}, "Device does not support either heating or cooling. No matching profile")
return
else
profile_name = profile_name .. thermostat_modes
end

if profile_name == "room-air-conditioner-humidity-fan-wind-heating-cooling" then
profile_name = "room-air-conditioner"
end

if not running_state_supported and profile_name == "room-air-conditioner-fan-heating-cooling" then
if not running_state_supported then
profile_name = profile_name .. "-nostate"
end