Skip to content

[Aqara] Update Aqara Door and Window Sensor T1 driver #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Aqara] Update Aqara Door and Window Sensor T1 driver #2113

wants to merge 3 commits into from
+209 −51

Conversation

seojune79
Copy link
Contributor

@seojune79 seojune79 commented May 7, 2025 •
edited
Loading

…ol, changed capability from battery to batteryLevel, and applied battery info in status messages.

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@seojune79
Update Aqara Door and Window Sensor T1 driver: enabled private protoc…
7093431 
…ol, changed capability from battery to batteryLevel, and applied battery info in status messages.
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/VD2NLkzmxNj5

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025 •
edited
Loading

Test Results

   66 files  ± 0    427 suites  +2   0s ⏱️ ±0s
2 200 tests +25  2 200 ✅ +25  0 💤 ±0  0 ❌ ±0 
3 749 runs  +41  3 749 ✅ +41  0 💤 ±0  0 ❌ ±0 

Results for commit 74d1039. ± Comparison against base commit d773c03.

This pull request removes 3 and adds 28 tests. Note that renamed tests count towards both. 
On changing the operatinalState to STOPPED, robotCleanerOperatingState must be set to the appropriate value
closed contact events
open contact events

Battery percentage report should be handled (motion illuminance)
Clear alarm and smokeDetector states, and read firmware version when the device is added
Configure should configure all necessary attributes(motion illuminance)
Handle single press sequence
Health check should check all relevant attributes(motion illuminance)
Profile should change to Motion Illuminance
Refresh necessary attributes(motion illuminance)
Reported motion illuminance should be handled: active
Reported motion illuminance should be handled: inactive
Should detect newer firmware version and use correct endian format to turn off the siren
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025 •
edited
Loading

File Coverage
All files 99% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/smartsense-multi/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/multi-sensor/init.lua 97% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 74d1039

inasail
inasail reviewed May 7, 2025
View reviewed changes
drivers/SmartThings/zigbee-contact/src/aqara/init.lua
local PRIVATE_CLUSTER_ID = 0xFCC0
local PRIVATE_ATTRIBUTE_ID = 0x0009
local PRIVATE_HEART_BATTERY_ENERGY_ID = 0x00F7

local FINGERPRINTS = {
{ mfr = "LUMI", model = "lumi.magnet.agl02" }
}

local CONFIGURATIONS = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add the configureReport for on/off cluster like...

{
cluster = OnOff.ID,
attribute = OnOff.attributes.OnOff.ID,
minimum_interval = 30,
maximum_interval = 3600,
data_type = OnOff.attributes.OnOff.base_type,
reportable_change = 1
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added the corresponding configureReport for the On/Off cluster.

greens
greens reviewed May 14, 2025
View reviewed changes
drivers/SmartThings/zigbee-contact/profiles/contact-batteryLevel-profile.yml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please omit profile from the filename, this is a pattern we have moved away from

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the the profile file name.

greens
greens reviewed May 14, 2025
View reviewed changes
drivers/SmartThings/zigbee-contact/src/test/test_aqara_contact_sensor.lua Outdated
Comment on lines 1 to 13
-- Copyright 2022 SmartThings
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep the copyright notice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have kept the copyright notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greens greens greens left review comments

@inasail inasail inasail left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seojune79 @greens @inasail