Initial version, adding support for frient Motion Sensor/Pro #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 67 files 441 suites 0s ⏱️ Results for commit 5b91c4c. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 5b91c4c |
…motion_sensor.lua and test_frient_motion_sensor_pro.lua
greens
reviewed
May 20, 2025
greens
reviewed
May 20, 2025
KKlimczukS
requested review from
greens and
cbaumler
and removed request for
cbaumler
greens
approved these changes
May 27, 2025
nickolas-deboom
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Initial version, adding support for frient Motion Sensor/Pro * Fix 1 according to test results * Fix 2: Deprecated test. These devices are now covered by test_frient_motion_sensor.lua and test_frient_motion_sensor_pro.lua * Fix 3 - restoring previous format * Fix 4 - according to feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Adding motion delay settings. Adding tamper detection. Adding illuminance measurements. Adding temperature measurements.
Summary of Completed Tests
The driver has been tested on actual device samples. Unit tests included and run.