Skip to content

Conversation

@nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Jun 4, 2025

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

The subdriver existed to handle devices that send position updates while the shade is in motion. This PR integrates the functionality from the subdriver into the main driver in order to avoid having to maintain a subdriver.

Summary of Completed Tests

Needs testing on device.

@nickolas-deboom nickolas-deboom force-pushed the matter-window-covering-integrate-subdriver branch from dd1215c to 3ef9c95 Compare June 4, 2025 19:23
@github-actions
Copy link

github-actions bot commented Jun 4, 2025

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

File Coverage
All files 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/init.lua 90%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against a146957

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Test Results

   69 files    449 suites   0s ⏱️
2 331 tests 2 331 ✅ 0 💤 0 ❌
3 923 runs  3 923 ✅ 0 💤 0 ❌

Results for commit a146957.

♻️ This comment has been updated with latest results.

@nickolas-deboom nickolas-deboom force-pushed the matter-window-covering-integrate-subdriver branch 4 times, most recently from fcb6926 to a85d71c Compare August 25, 2025 19:38
The subdriver existed to handle devices that send position updates while
the shade is in motion. This PR integrates the functionality from the
subdriver into the main driver in order to avoid having to maintain a
subdriver.
@nickolas-deboom nickolas-deboom force-pushed the matter-window-covering-integrate-subdriver branch from a85d71c to a146957 Compare August 25, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants