Integrate the matter window covering subdriver into the main driver#2169
Open
nickolas-deboom wants to merge 1 commit intomainfrom
Open
Integrate the matter window covering subdriver into the main driver#2169nickolas-deboom wants to merge 1 commit intomainfrom
nickolas-deboom wants to merge 1 commit intomainfrom
Conversation
nickolas-deboom
force-pushed
the
matter-window-covering-integrate-subdriver
branch
from
dd1215c to
3ef9c95
Compare
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a146957 |
Test Results 69 files 449 suites 0s ⏱️ Results for commit a146957. ♻️ This comment has been updated with latest results. |
nickolas-deboom
force-pushed
the
matter-window-covering-integrate-subdriver
branch
4 times, most recently
from
fcb6926 to
a85d71c
Compare
The subdriver existed to handle devices that send position updates while the shade is in motion. This PR integrates the functionality from the subdriver into the main driver in order to avoid having to maintain a subdriver.
nickolas-deboom
force-pushed
the
matter-window-covering-integrate-subdriver
branch
from
a85d71c to
a146957
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
The subdriver existed to handle devices that send position updates while the shade is in motion. This PR integrates the functionality from the subdriver into the main driver in order to avoid having to maintain a subdriver.
Summary of Completed Tests
Needs testing on device.