Skip to content

philips-hue: Refresh device on online sse update #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

NoahCornell
Copy link
Contributor

@NoahCornell NoahCornell commented Jun 6, 2025

Check all that apply

Type of Change

  • Bug fix

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Inject refresh command when we receive a zigbee connectivity update from the sse stream. Fixes an issue where device cards are grayed out after discovery when the device was offline and then went online.

Summary of Completed Tests

Tested on my hub and confirmed that once the devices come online that they are not grayed out and are controllable.

Copy link

github-actions bot commented Jun 6, 2025

Channel deleted.

Copy link

github-actions bot commented Jun 6, 2025

Test Results

   67 files    440 suites   0s ⏱️
2 255 tests 2 255 ✅ 0 💤 0 ❌
3 847 runs  3 847 ✅ 0 💤 0 ❌

Results for commit dbdc1c7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 6, 2025

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against dbdc1c7

@NoahCornell NoahCornell requested review from dljsjr and varzac June 6, 2025 16:04
Copy link
Member

@dljsjr dljsjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, not a blocker in any way.

@NoahCornell NoahCornell force-pushed the philips_hue_refresh_on_connect branch from d124e60 to dbdc1c7 Compare June 6, 2025 16:23
@NoahCornell NoahCornell merged commit 6cecf1b into main Jun 9, 2025
11 checks passed
@NoahCornell NoahCornell deleted the philips_hue_refresh_on_connect branch June 9, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants