Added support for frient switch devices #2208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1259705 |
greens
reviewed
Jun 25, 2025
| maximum_interval = 600, | ||
| data_type = Alarms.attributes.AlarmCount.base_type, | ||
| reportable_change = 1, | ||
|
|
greens
reviewed
Jun 25, 2025
greens
reviewed
Jun 25, 2025
|
|
||
| local function alarm_report_handler(driver, device, zb_rx) | ||
| local alarm_status = zb_rx.body.zcl_body | ||
| log.error("Received alarm report:"..util.stringify_table(zb_rx.body.zcl_body, nil, true)) |
There was a problem hiding this comment.
This seems like a debug statement, and I expect this message is already logged by the driver framework.
greens
reviewed
Jun 25, 2025
greens
reviewed
Jun 25, 2025
| local multiplier = device:get_field(VOLTAGE_MEASUREMENT_MULTIPLIER_KEY) or 1 | ||
| local divisor = device:get_field(VOLTAGE_MEASUREMENT_DIVISOR_KEY) or 1 | ||
|
|
||
| if divisor == 0 then |
There was a problem hiding this comment.
If this is a concern, I would put the check where you write the value to VOLTAGE_MEASUREMENT_DIVISOR_KEY.
greens
reviewed
Jun 25, 2025
Comment on lines
88
to
108
| local function current_measurement_divisor_handler(driver, device, divisor, zb_rx) | ||
| log.info("current divisor value = ", divisor.value) | ||
| local raw_value = divisor.value | ||
| device:set_field(CURRENT_MEASUREMENT_DIVISOR_KEY, raw_value, { persist = true }) | ||
| end | ||
|
|
||
| local function current_measurement_multiplier_handler(driver, device, multiplier, zb_rx) | ||
| log.info("current multipl value = ", multiplier.value) | ||
| local raw_value = multiplier.value | ||
| device:set_field(CURRENT_MEASUREMENT_MULTIPLIER_KEY, raw_value, { persist = true }) | ||
| end | ||
|
|
||
| local function voltage_measurement_divisor_handler(driver, device, divisor, zb_rx) | ||
| log.info("V divisor value = ", divisor.value) | ||
|
|
||
| local raw_value = divisor.value | ||
| device:set_field(VOLTAGE_MEASUREMENT_DIVISOR_KEY, raw_value, { persist = true }) | ||
| end | ||
|
|
||
| local function voltage_measurement_multiplier_handler(driver, device, multiplier, zb_rx) | ||
| log.info("Volt Multiplayer value = ") |
There was a problem hiding this comment.
several log statements here that ought to be removed. This one doesn't actually log any values.
greens
reviewed
Jun 26, 2025
| cluster = ElectricalMeasurement.ID, | ||
| attribute = ElectricalMeasurement.attributes.ActivePower.ID, | ||
| minimum_interval = 5, | ||
| maximum_interval = 600, |
There was a problem hiding this comment.
Our default max here is one hour, rather than 5 minutes. Is there a particular reason you've chosen a shorter max interval? Because of the reportable change, any updates to the value itself should still come in (provided they're not more frequent than the minimum interval), so we're wondering if there's a specific reason you want to see the current value reported every five minutes.
If not, we'd appreciate you sticking with our default configurations.
…PR comments. Updated test file
greens
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests