ZLL: Use Native / Default handlers #2440
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6e40aa4 |
wkhenon
force-pushed
the
defaults-for-zll-subdrivers
branch
from
f541dd9 to
5a0c5ab
Compare
wkhenon
force-pushed
the
defaults-for-zll-subdrivers
branch
from
cce4958 to
7fc35dc
Compare
wkhenon
force-pushed
the
defaults-for-zll-subdrivers
branch
2 times, most recently
from
d037473 to
32d969f
Compare
wkhenon
force-pushed
the
defaults-for-zll-subdrivers
branch
from
32d969f to
6e40aa4
Compare
wkhenon
commented
Oct 6, 2025
|
|
||
| test.socket.zigbee:__expect_send({ mock_device.id, OnOff.attributes.OnOff:read(mock_device) }) | ||
| test.socket.zigbee:__expect_send({ mock_device.id, Level.attributes.CurrentLevel:read(mock_device) }) | ||
| if version.api <= 15 then |
There was a problem hiding this comment.
I was having issues running the setColorTemperature tests locally with this operator set to <= (no issues with <). Would this be pointing to a problem with how I'm using the version? Or is there some Lua magic that I'm missing?
There was a problem hiding this comment.
Well the way you've written things, wouldn't the initial on/offs also not be sent when the native handlers are used?
@cjswedes probably has more insight here.
wkhenon
requested review from
greens,
bretschuring,
cbaumler,
cjswedes,
pegor-karoglanian and
tpmanley
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
This pull request defaults handing for
on,off,set_level, andset_color_temperaturein the ZLL sub-driver back to the mainzigbee-switchdriver.Summary of Completed Tests