Skip to content

Conversation

HunsupJung
Copy link
Collaborator

@HunsupJung HunsupJung commented Oct 1, 2025

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This PR is for supporting Routine of robotCleanerOperatingState Capability and includes follows.

  1. Variables used in duplicate were changed to global variables.
  2. rvc_operational_state_list_attr_handler has been added to support Condition of Routine.
  3. handle_rvc_operational_state_accepted_command_list has been updated to update supportedCommands
  4. driverSwitched has been added to execute handle_rvc_operational_state_accepted_command_list after updating driver.

Summary of Completed Tests

Copy link

github-actions bot commented Oct 1, 2025

Copy link

github-actions bot commented Oct 1, 2025

Test Results

   71 files    452 suites   0s ⏱️
2 344 tests 2 325 ✅ 0 💤 19 ❌
3 952 runs  3 933 ✅ 0 💤 19 ❌

For more details on these failures, see this check.

Results for commit 388bea7.

Copy link

github-actions bot commented Oct 1, 2025

File Coverage
All files 49%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/init.lua 22%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/embedded_cluster_utils.lua 27%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/ServiceArea/types/LandmarkInfoStruct.lua 59%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/ServiceArea/types/AreaInfoStruct.lua 59%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/ServiceArea/types/AreaStruct.lua 63%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/ServiceArea/types/SelectAreasStatus.lua 69%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/Global/types/AreaTypeTag.lua 66%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/Global/types/LandmarkTag.lua 67%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/Global/types/LocationDescriptorStruct.lua 63%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/Global/types/RelativePositionTag.lua 68%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 388bea7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant