WWSTCERT-8423/8426 [Aqara] Wireless Remote Switch T1(Single/Double) #2458
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 458 suites 0s ⏱️ Results for commit 9e6f588. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 9e6f588 |
| - id: refresh | ||
| version: 1 | ||
| categories: | ||
| - name: Button |
There was a problem hiding this comment.
@seojune79 Could you change this to RemoteController also?
There was a problem hiding this comment.
@Kwang-Hui Yes, I've reflected that.
…ontroller' in the 'aqara-double-buttons' profile
| end | ||
| device:emit_event(evt) | ||
| if btn_evt_cnt > 1 then | ||
| device:emit_component_event(device.profile.components[COMP_LIST[end_point]], evt) |
There was a problem hiding this comment.
It seems like button events will only be emitted from the all component when they come from endpoint 3, but they will always be emitted from the main endpoint. That's a bit confusing.
In the past we've used the main component as an any/all component for button presses. It's a pattern with some precedent. Did you avoid that with your profiles because the name is not descriptive?
There was a problem hiding this comment.
To monitor all button events on the card, they are set to be emitted from the main component. Endpoint 3 triggers an event when both button 1 and button 2 are pressed simultaneously, so the all component is used to indicate that both buttons must be pressed together.
There was a problem hiding this comment.
@greens This device appears to have two physical buttons, but it actually functions like a 3-button device. When both buttons are pressed simultaneously, it triggers the button event for the all component, but not for button1 or button2. However, when naming it button3, it would be difficult for users to associate it with pressing simultaneously, so it was suggested to create it as an all component.
The function of the main component is intended to update the main device simultaneously whenever an event occurs at any endpoint, just like other multi-button devices.
If you have better idea about all component naming, please let me know
There was a problem hiding this comment.
I'd suggest both, but it's not a big deal. I understand now.
There was a problem hiding this comment.
rename to one-button-batteryLevel and include the firmwareUpdate capability.
greens
changed the title
greens
changed the title
…named the file to one-button-batteryLevel.yml.
| [1] = { | ||
| id = 1, | ||
| manufacturer = "LUMI", | ||
| model = "lumi.remote.acn003", |
There was a problem hiding this comment.
This device should still be using the one-button-battery profile, as you have not updated the fingerprint.
There was a problem hiding this comment.
I have updated the fingerprints for all Aqara Button Devices by implementing the batteryLevel capability.
3 participants
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests