WWSTCERT-8419/8461 Aqara dimmer controller t1 #2468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 457 suites 0s ⏱️ Results for commit 875c45a. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 875c45a |
greens
reviewed
Oct 23, 2025
|
|
||
| local devices = { | ||
| AQARA_LIGHT = { | ||
| MATCHING_MATRIX = { mfr = "LUMI", model = "lumi.light.acn004" }, |
There was a problem hiding this comment.
you should just be able to add the new model here rather than duplicating this map entirely
greens
reviewed
Oct 23, 2025
Comment on lines
+58
to
+67
| local function init(self, device) | ||
| local min = 2700 | ||
| local max = 6000 | ||
|
|
||
| if device:get_model() == "lumi.light.cwacn1" then | ||
| max = 6500 | ||
| end | ||
| device:emit_event(capabilities.colorTemperature.colorTemperatureRange({ minimum = min, maximum = max })) | ||
| end | ||
|
|
There was a problem hiding this comment.
I understand the instinct here so that existing devices get this change, but we do not want this event to fire every time the driver starts.
I would add this event to the added handler as well, and a follow-up PR a week later should be created to remove this code here in init. I'd also add gating to check for an existing colorTemperatureRange value before emitting this event.
greens
changed the title
greens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests