Matter Switch: Update Vendor Overrides #2480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 71 files 459 suites 0s ⏱️ Results for commit 118fe38. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 118fe38 |
drivers/SmartThings/matter-switch/src/test/test_multi_switch_parent_child_lights.lua
Outdated
Show resolved
Hide resolved
ctowns
reviewed
Oct 23, 2025
gharveymn
reviewed
Oct 28, 2025
gharveymn
reviewed
Oct 28, 2025
gharveymn
reviewed
Oct 28, 2025
drivers/SmartThings/matter-switch/src/utils/device_configuration.lua
Outdated
Show resolved
Hide resolved
hcarter-775
force-pushed
the
fix-vendor-overrides
branch
from
620966c to
ec112fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I updated/consolidated the vendor override logic so it is cleaner.
This could be removed, but I also added a
get_endpoints_by_device_typehelper function in this PR. It could be done separately, but I think the changed logic here is very obvious.Summary of Completed Tests
Since this only affects device behavior that is specifically gated by an override, unit tests properly show that all cases are still supported.
Piggy-backing the
get_endpoints_by_dtfunction addition, I have updated thetest_matter_bridgefunction since the original version did not catch a bug that I later patched.