Add greater dynamic profiling to matter switch #2481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 71 files 459 suites 0s ⏱️ Results for commit 4e103bd. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 4e103bd |
hcarter-775
force-pushed
the
update-metadata-switch
branch
from
34595bf to
38f240f
Compare
ctowns
reviewed
Oct 23, 2025
drivers/SmartThings/matter-switch/src/utils/device_configuration.lua
Outdated
Show resolved
Hide resolved
ctowns
reviewed
Oct 23, 2025
hcarter-775
force-pushed
the
update-metadata-switch
branch
from
ca60426 to
fb3f845
Compare
Contributor
|
Have you tested with plugs that support energy clusters? |
Contributor
Author
Unit tests catch the case that anything has changed in that regard, and no functionality would be changed as far as this path goes. That is to say, if a plug correctly profiles then the electrical sensor portion would not be breaking (and thus can be confirmed in unit tests) |
hcarter-775
force-pushed
the
update-metadata-switch
branch
from
fb3f845 to
73aa8dc
Compare
Contributor
|
I took another pass through this PR and it's looking good from my perspective 👍 I'm approving now but I had one more comment about a unit test that would be good to add before merging |
nickolas-deboom
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Right now, nearly all Light / PlugIn / Switch fingerprints are static in the Matter Switch driver. This update makes it so that more dynamic ability to re-profiling these devices. It also attempts to streamline some of this handling.
Though there are a few cases where parent/child device composition may cause a parent device to mis-profile (which this would fix- ex. a child with more support than its parent will cause the parent to misprofile with the more robust child support), this change mostly aims at making dynamic profiling more straightforward in later work.
Summary of Completed Tests
All Light superset devices were onboarded with correct profile.
All Plug devices were onboarded with correct profile.
Specialty devices show continued correct profiling through unit tests.