Matter Lock: Use Door Lock Device type in Lock Modular logic #2494
Conversation
hcarter-775
requested review from
HunsupJung,
ctowns,
gharveymn,
greens and
nickolas-deboom
|
Invitation URL: |
Test Results 71 files 458 suites 0s ⏱️ Results for commit c60da06. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against c60da06 |
| break | ||
| local door_lock_ep_data | ||
| for _, ep_data in ipairs(device.endpoints) do | ||
| if ep_data.device_types[1].device_type_id == DEVICE_TYPE_ID.DOOR_LOCK then |
There was a problem hiding this comment.
Could the endpoint have multiple device types?
There was a problem hiding this comment.
per spec, application device types cannot have >1 device type on an endpoint
There was a problem hiding this comment.
Also, application device types cannot be supported on another endpoint as a secondary.
There was a problem hiding this comment.
Discussed offline. Here's the spec wording:
9.2.1. Endpoint Requirements
[9.18] Each Simple endpoint SHALL support exactly one Application device type with the exception that, the endpoint MAY support additional device types which are subsets of the Application device type (the superset). See Section 9.2.10, “Superset Device Types” for cluster requirements of superset devices.
where the complement of simple endpoints are dynamic endpoints, which aren't used by us (now? ever?).
2 participants
Description of Change
Slightly reduces number of checks in the lock modular logic by using the device type as a first check, before searching for the door lock cluster to map a profile to.
Summary of Completed Tests
Unit tests continue to pass, and VDA onboarding indicated a correct modular profile was selected.