Add WeakLoopHandle
#216
Merged
Add WeakLoopHandle
#216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Paraworker
force-pushed
the
weak-loop-handle
branch
3 times, most recently
from
f01f6e5 to
59180c7
Compare
Paraworker
force-pushed
the
weak-loop-handle
branch
from
59180c7 to
8494515
Compare
Paraworker
force-pushed
the
weak-loop-handle
branch
2 times, most recently
from
a4b89b6 to
4af5985
Compare
notgull
approved these changes
Jan 11, 2025
Paraworker
force-pushed
the
weak-loop-handle
branch
from
4af5985 to
d5f6519
Compare
|
Rebased. |
|
It looks like 1.63 CI is failing for some reason |
Paraworker
force-pushed
the
weak-loop-handle
branch
from
d5f6519 to
2ea5738
Compare
Looks like it requires |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 85.45% 86.28% +0.82%
==========================================
Files 13 15 +2
Lines 1877 2078 +201
==========================================
+ Hits 1604 1793 +189
- Misses 273 285 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
WeakLoopHandleto avoid reference cycles.Closes #212