- 
                Notifications
    
You must be signed in to change notification settings  - Fork 621
 
CMake #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            SamuelMarks
  wants to merge
  10,000
  commits into
  Snapchat:main_pre_flash
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
offscale:cmake
  
      
      
   
  
    
  
  
  
 
  
      
    base: main_pre_flash
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            CMake #421
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Change min tested version to 18.04
…e are still issues with the sentinel tests but attempting to bind only to localhost causes failures
comparision -> comparison
… mode. (Snapchat#696) Co-authored-by: Karthick Ariyaratnam (A) <[email protected]>
…th the runtime value during config rewrite.
| 
           Ouch: 
 Merging latest, should be able to resolve issues next weekend EDIT - Maybe you can change what HEAD this PR popints to, as it's now trying to merge 10,000 commits?!  | 
    
…files ; [src/modules/CMakeLists.txt] Initial add for modules ; [CMakeLists.txt] Bump version
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
#3 was from over 3 years ago, so thought I'd restart the conversation.
Can probably contribute CMake support myself for y'all. Main advantages:
cmake), testing (ctest,cdash), packaging (cpack)…and, along with
vcpkg—or I suppose any package manager + pkg-config or what-have-you—one can:PS: I note your interest in supporting FreeBSD. That shouldn't be too difficult, particularly with this PR. Ditto for macOS. As for Windows, that'll be a more complex contribution… see my redis/redis#9728