Merged
Conversation
- add unregister method - make sure it's thread safe - refresh documentation
…p-Mobile/SnappTheming into feature/image-manager-tests # Conflicts: # Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift # Tests/SnappThemingTests/SnappThemingImageManagerTests.swift
v-volod
approved these changes
Nov 11, 2025
Sources/SnappTheming/Theme/SnappThemingImageProcessorsRegistry.swift
Outdated
Show resolved
Hide resolved
….swift Co-authored-by: Volodymyr Voiko <[email protected]>
🛡️ Code Coverage Report
Generated by Swift Coverage Action. |
oleksiikolomiietssnapp
added a commit
that referenced
this pull request
Nov 11, 2025
Version bump to 0.1.3 combining multiple improvements across the framework: - **URL Context for Image Processing** (#135): Extended `SnappThemingExternalImageProcessorProtocol` to provide URL context alongside data to image processors, critical for formats like SVG that need resource context - **InsettableShape Support** (#130): Upgraded `SnappThemingShapeType` to support `InsettableShape` builder pattern for better SwiftUI integration - **Swift 6 Migration** (#129): Migrated example apps to Swift 6 with related compatibility fixes - **Caching Improvements**: Ensured images are cached before extraction to prevent rendering issues when switching themes - **Image Manager Testing & Registry Enhancements** (#136) - Full unit test suite for `SnappThemingImageManager` functionality - Added `unregister()` method for dynamic processor lifecycle management - Ensured thread-safe access to `SnappThemingImageProcessorsRegistry` - Refreshed and clarified registry API documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SnappThemingImageProcessorsRegistrychanges:SnappThemingImageManager