Skip to content

Fixing CI #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksiikolomiietssnapp merged 4 commits into from
Nov 8, 2025
Merged

Fixing CI #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d037ad
try to use static
oleksiikolomiietssnapp Nov 8, 2025
01e4bdd
Update swift.yml
oleksiikolomiietssnapp Nov 8, 2025
cdbf319
moved dummy data
oleksiikolomiietssnapp Nov 8, 2025
3112777
Merge branch 'feature/image-namager-tests-fix-ci' of https://github.c…
oleksiikolomiietssnapp Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/swift.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main", "next" ]
branches: [ "main", "next", "feature/image-manager-tests" ]

jobs:
coverage:
Expand Down
3 changes: 1 addition & 2 deletions Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ import SnappTheming
import UniformTypeIdentifiers

final class MockExternalProcessor: SnappThemingExternalImageProcessorProtocol {
let dummyImage = SnappThemingImage(systemSymbolName: "pencil", accessibilityDescription: "test")
func process(_ object: SnappTheming.SnappThemingImageObject, of type: UTType) -> SnappThemingImage? {
dummyImage
SnappThemingImage(systemSymbolName: "pencil", accessibilityDescription: "test")
}
}
3 changes: 2 additions & 1 deletion Tests/SnappThemingTests/SnappThemingImageManagerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ struct SnappThemingImageManagerTests {

@Test func testPreparingImage_External() throws {
let mock = MockExternalProcessor()
let mockImage = SnappThemingImage(systemSymbolName: "pencil", accessibilityDescription: "test")
SnappThemingImageProcessorsRegistry.shared.register(mock)
let manager: SnappThemingImageManager = SnappThemingImageManagerDefault(
.withFileExistTrue,
Expand All @@ -66,7 +67,7 @@ struct SnappThemingImageManagerTests {
#expect(object.url == nil)
#expect(object.data == dataURI.data)
let image = try #require(manager.image(from: object, of: dataURI.type))
#expect(image.size == mock.dummyImage?.size)
#expect(image.size == mockImage?.size)

SnappThemingImageProcessorsRegistry.shared.unregister(MockExternalProcessor.self)
}
Expand Down