fix(proxy): retry missing response.created once - #1483
Closed
mhooooo wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Superseded by #1484, stacked on #1481. The retry-only approach here shortens one acknowledgement wait but does not converge when durable bridge ownership and the broad legacy session row remain persistently contradictory. #1484 fixes that pre-dispatch ownership loop while preserving the durable owner and fail-closed specific ownership boundaries. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover Codex Responses streams without exposing the reconnect loop when either:
response.createreceives noresponse.created; orEvery replay stays bounded to one attempt, preserves the original request budget and required account, and remains fail-closed whenever dispatch may have begun.
Type of change
fix:— bug fixfeat:— new user-facing capabilityrefactor:— internal refactordocs:— documentation onlychore:/ci:/build:— toolingtest:— test-only changeLinked issue: Refs #1393
OpenSpec
Change directory:
openspec/changes/retry-missing-response-created-once/Changes
response.createdacknowledgement window at 30 seconds instead of 240 seconds.Root cause and impact
The existing bridge watchdog always failed after a missing acknowledgement, even when its guarded replay path could safely recover. Separately, both HTTP and direct-WebSocket clients could reuse a normally closed warm upstream and surface a client reconnect before the next send.
The proxy now distinguishes a provably undispatched request from an ambiguous send. Only the former receives one exact same-account resend. Existing lifecycle, visibility, sibling-request, continuation, file-ownership, admission, and one-replay guards remain authoritative.
Simplicity
Validation
Live exact-revision verification also completed authenticated
/models, HTTP Responses, and direct-WebSocket Responses requests through the locally deployed combined image.Checklist
CHANGELOG.mdis unchanged