feat(accounts): add per-account usage limits by NikitaMGrimm · Pull Request #1528 · Soju06/codex-lb

NikitaMGrimm · 2026-07-29T11:46:09Z

Summary

Adds an optional per-account usage cap so operators can reserve upstream quota for direct use. The cap applies across API keys and routing strategies.
The limit applies to both the 5-hour and weekly quota windows. Routing stops when either window reaches the configured percentage, making sure to preserve the remaining share.

Fixes #631

Type of change

feat: — new user-facing feature or capability

OpenSpec

This PR includes an OpenSpec change

Change directory: openspec/changes/add-account-usage-limits/

Changes

Store a reversible maximum-used percentage on each account.
Exclude capped accounts before sticky, policy, fallback, and additional-quota routing.
Add the account API, migration, dashboard controls, documentation, and tests.

Review notes

The selector uses standard usage rows already loaded into the cached selection snapshot; it adds no usage queries. Evaluation is linear in the candidate count.

Enabled limits fail closed when relevant telemetry is missing or older than max(2 × refresh interval, 180 seconds). The API and dashboard expose this as data_unavailable; fresh below-cap telemetry restores eligibility automatically.

Simplicity

The feature defaults to off.
No new setup step or setting is required.
No README, .env.example, or core navigation growth.

Test plan

uv run pytest -q tests/unit/test_account_usage_limits.py tests/unit/test_load_balancer.py tests/unit/test_load_balancer_concurrency.py tests/unit/test_proxy_utils.py tests/unit/test_accounts_service_transitions.py -k 'usage_limit or usage_limited'
# 32 passed

uv run pytest -q tests/integration/test_accounts_api_extended.py tests/integration/test_migrations.py -k 'usage_limit'
# 6 passed

npx -y @fission-ai/openspec@latest validate --specs
# 48 passed

Screenshots / output

limit not set:

limit set:

current set limit disabled:
<img width="1389" height="309" alt="image" src="https://github.com/user-attachments/assets/d057afad-abfb-489d-b1ef-0888ddca91f6" /

Checklist

Summary by CodeRabbit

New Features
- Added configurable per-account usage limits with percentage thresholds.
- Added controls to enable, disable, update, or remove limits.
- Added usage-limit status, summaries, warnings, and dashboard badges.
- Routing excludes accounts at or beyond limits and fails safely when usage data is unavailable.
- Enforced limits across HTTP, WebSocket, sticky, fallback, and warmup flows.
Documentation
- Documented usage-limit behavior and routing effects.
Localization
- Added English, Korean, and Chinese translations for controls and messages.

NikitaMGrimm · 2026-07-29T12:30:09Z

Regarding the UI design:

Alternatively, it could possibly work like this:
Enabled Toggle always shows, default is off.
Once someone enables the toggle, it gets set to 100% by default unless a prior value has been set.
New limits can then be set when toggled on.
Clear saved limit button would then be gone.

One potential problem that exists right now if the above is implemented:
If a limit of 100% usage is set and enabled, it will still block routing after 100% is used up (after 0% of the limit is still available). There is no special case at 100% where blocking is effectively disabled at this point. This might cause requests after 100% to be "wasted" even though Codex might still allow them. (ongoing work and subagents before compactification triggers and input tokens aren't cached anymore)

Also delayed telemetry or in-flight requests can cause some unpreventable overshoot with the current implementation.
(Not too bad in my testing. Theoretically possible to try and predict the overshoot even with delayed telemetry but that might cause some bigger changes?)

Soju06 · 2026-07-30T07:27:04Z

Triage note: this is a feature, so per the release train it queues behind the v1.23.0 stable cut (#1472) even once ready — no rush on your side. Meanwhile: (1) @Soju06, the author raised a concrete UI design question (always-visible enable toggle defaulting to 100% vs. the current clear-saved-limit control) that needs a maintainer call before the dashboard surface settles; (2) CI runs need maintainer workflow approval to start. Design looks aligned with the balancer-module ratchet (new app/core/balancer module, no selector hot-path DB I/O claimed) — we'll verify the app/core -> app/modules import boundary at review time.

NikitaMGrimm · 2026-08-09T15:41:28Z

Rebased. When you have time, could you approve the CI workflow and let me know if we should change the UI or keep the current design from the screenshots?
@Soju06

Komzpa · 2026-08-09T21:24:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3909d647c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

NikitaMGrimm · 2026-08-10T13:48:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 091aa1515f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

NikitaMGrimm · 2026-08-10T16:10:45Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f969778d35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

NikitaMGrimm · 2026-08-10T17:58:41Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6518cdc407

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

NikitaMGrimm · 2026-08-10T18:30:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe2833649c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

NikitaMGrimm · 2026-08-10T20:10:27Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b7ec8519ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

NikitaMGrimm · 2026-08-10T20:50:17Z

@codex review

chatgpt-codex-connector · 2026-08-10T20:50:25Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Soju06 · 2026-08-19T09:30:54Z

Triage re-review after your 0818 push — this is now merge-ready on technical grounds except for one small fix: the migration reparent onto 20260806_030000_add_api_key_allowed_reasoning_efforts means that revision is no longer the alembic head, so tests/unit/test_db_migrate.py::test_api_key_reasoning_policy_migration_round_trips_from_current_parent fails at your head (the head-pin assertion needs 20260728_010000_add_account_usage_limits as the expected head). Verified it's the only PR-caused failure in the full unit suite. Once you push that, I'll approve the fork CI runs so the Postgres matrix exercises the migration path.

Answering the open 07-29 UI question explicitly since it was never closed out: the current set/clear control from your screenshots is accepted — no need for an always-visible toggle defaulting to 100%.

Everything else verified: WS-harness blocker fixed, quota interaction correctly isolated from ignore_standard_quota, fail-closed staleness behavior looks right, migration itself is well-formed, 20/20 review threads resolved. Note the 'db migration' label coordination: if another migration-bearing PR lands first you'll need one more reparent + the same head-pin update.

github-actions Bot added the db migration PR changes Alembic database migrations; maintainer must coordinate merge order label Jul 29, 2026

Soju06 mentioned this pull request Aug 4, 2026

fix(proxy): persist file ownership across replicas #1521

Merged

21 tasks

Komzpa added the needs rebase Needs rebase or conflict repair against current main label Aug 6, 2026

NikitaMGrimm force-pushed the feat/per-account-usage-limits branch 2 times, most recently from 9720787 to d3909d6 Compare August 9, 2026 15:18

Komzpa removed the needs rebase Needs rebase or conflict repair against current main label Aug 9, 2026

chatgpt-codex-connector Bot reviewed Aug 9, 2026

View reviewed changes

Komzpa added the 🤖 codex: needs work [@codex review] raised an issue label Aug 9, 2026

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread app/core/balancer/logic.py Outdated

Comment thread app/modules/proxy/load_balancer.py Outdated

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread app/modules/quota_planner/warmup.py Outdated

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread app/modules/proxy/api.py Outdated

Comment thread app/modules/quota_planner/logic.py

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread app/modules/proxy/_load_balancer/unbound_selection.py Outdated

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread app/core/usage/account_limits.py

Comment thread app/modules/proxy/_load_balancer/sticky_selection.py

Komzpa added 🤖 codex: needs work [@codex review] raised an issue needs rebase Needs rebase or conflict repair against current main and removed 🤖 codex: needs work [@codex review] raised an issue labels Aug 10, 2026

NikitaMGrimm and others added 26 commits August 18, 2026 15:16

feat(accounts): add per-account usage limits

25c5952

refactor(accounts): simplify usage limit controls

97a3951

test(accounts): adapt sticky lookup after rebase

7fa6d90

fix(db): rebase usage limit migration

d4c1d86

fix(accounts): address usage limit review findings

8b576de

fix(accounts): enforce limits on bridge and warmup

f8acb29

fix(quota-planner): shield cleanup through cancellation

ce740cc

fix(accounts): harden admission and planner limits

b643ad6

fix(proxy): exclude unroutable fair-share capacity

d452c5e

fix(accounts): tighten usage and cap eligibility

57b8c81

fix(proxy): enforce usage limits on websocket turns

745a7a7

fix(db): reparent usage limits migration

b552bdc

refactor(proxy): keep local error codes in support

d0eec99

test(proxy): isolate cancel drain from account limits

012a2c4

fix: reconcile usage limits with latest main

5368a9d

fix(proxy): centralize usage-limit routing eligibility

78ab133

fix(planner): preserve warmup authorization outcomes

d7201bb

fix(frontend): synchronize usage-limit controls

b6f3c8d

test(proxy): cover opportunistic account cap exclusion

b39d4c6

feat(dashboard): show reached account usage limits

892a9d0

fix(proxy): reject unavailable websocket owners

97f3749

test(proxy): isolate websocket owner policy probes

a066f49

fix(db): reparent usage limits migration after rebase

5125c6e

test(accounts): adapt sticky owner lookup after rebase

7ce8938

test(proxy): exercise persisted websocket owners

f078941

refactor(proxy): preserve selection snapshots compactly

ab6c3bd

NikitaMGrimm force-pushed the feat/per-account-usage-limits branch from 8be2a95 to ab6c3bd Compare August 18, 2026 13:56

test(db): update expected migration head

8298e89

coderabbitai Bot mentioned this pull request Aug 19, 2026

fix(warmup): warm paid-to-free transitions #1825

Open

18 tasks

Conversation

NikitaMGrimm commented Jul 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of change

OpenSpec

Changes

Review notes

Simplicity

Test plan

Screenshots / output

Checklist

Summary by CodeRabbit

Uh oh!

NikitaMGrimm commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Soju06 commented Jul 30, 2026

Uh oh!

NikitaMGrimm commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Komzpa commented Aug 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NikitaMGrimm commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

NikitaMGrimm commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

NikitaMGrimm commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

NikitaMGrimm commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

NikitaMGrimm commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

NikitaMGrimm commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 10, 2026

Uh oh!

Soju06 commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

NikitaMGrimm commented Jul 29, 2026 •

edited by coderabbitai Bot

Loading

NikitaMGrimm commented Jul 29, 2026 •

edited

Loading

NikitaMGrimm commented Aug 9, 2026 •

edited

Loading