fix(cache): recover invalidation after failed prime - #1544
Merged
Soju06 merged 1 commit intoAug 4, 2026
Conversation
mastertyko
marked this pull request as ready for review
July 30, 2026 11:08
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover cache-invalidation delivery after a transient startup baseline-prime
failure, so the first successful background poll cannot acknowledge a peer
version without invalidating already-warm routing state.
The root cause was that an uninitialized poller treated its first successful
background read as a callback-less baseline.
start()now ends baseline-onlyacquisition before spawning the poll task, while an explicit
prime()retrybefore
start()remains baseline-only.Type of change
fix:— bug fix (no behavior change beyond the bug)feat:— new user-facing feature or capabilityrefactor:— internal refactor (no behavior change, no API change)docs:— documentation onlychore:/ci:/build:— tooling, CI, packagingtest:— test-only changeLinked issue: None — no matching upstream issue was found in the bounded related-work search.
OpenSpec
Change directory:
openspec/changes/recover-cache-invalidation-after-prime-failure/Changes
starts without a recorded version baseline.
prime()retry beforebackground polling.
cache, account-routing refresh, and HTTP bridge-session reuse.
query-cachingandmodel-catalog-compatOpenSpec contracts.Test plan
The full repository-wide
pre-commit local-cigate was intentionally not runlocally; the focused Sensitive routing/cache suite, scoped lint/format/type
checks, strict OpenSpec validation, and independent diff review were completed.
Repository CI remains the authoritative integration gate.
Screenshots / output
Not applicable. This changes backend poller lifecycle behavior and has no
dashboard-visible surface; the real routing-cache and bridge-reuse seams are
covered by integration tests.
Checklist
<type>(<scope>)?: <subject>).environment examples, dashboard navigation, or UI defaults are added.