fix(proxy-responses): adapt explicit prompt cache controls - #1565
Open
Komzpa wants to merge 2 commits into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Collaborator
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent public explicit prompt-cache controls from causing
400responses onthe Codex subscription upstream. The subscription egress now omits unsupported
controls while preserving prompt text, order, and
prompt_cache_key; successfulfallbacks report their effective semantics in a response header.
Head:
ecc281960393c1be719dcfb07236c0d19744f3efType of change
fix:- bug fix (no behavior change beyond the bug)feat:- new user-facing feature or capabilityrefactor:- internal refactor (no behavior change, no API change)docs:- documentation onlychore:/ci:/build:- tooling, CI, packagingtest:- test-only changeLinked issue: None; this is a focused Responses compatibility regression.
OpenSpec
Change directory:
openspec/changes/adapt-subscription-prompt-cache-controls/The intentional divergence is limited to Codex subscription egress, whose
upstream rejects these public API controls. OpenAI-compatible model-source
egress keeps the public request unchanged.
Changes
prompt_cache_optionsand supported content-blockprompt_cache_breakpointfields only during subscription serialization.X-Codex-LB-Prompt-Cache-Mode: subscription-implicitafter asuccessful subscription fallback so clients can observe the semantic
downgrade.
/v1/responsesintegration regressions.Simplicity
.env.exampleentry, or dashboard navigation.Test plan
Output
A successful subscription request containing an explicit cache breakpoint now
returns:
X-Codex-LB-Prompt-Cache-Mode: subscription-implicitThe corresponding subscription wire payload retains
prompt_cache_keyandcontent but omits the unsupported explicit controls. The model-source negative
control retains all three fields and does not return the fallback header.
Checklist
CHANGELOG.mdis unchanged.