Penalize eventless HTTP bridge accounts - #1574
Open
Komzpa wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an HTTP bridge recovery gap where a
response.createsend that neverreceives
response.createdretires the stale bridge session but leaves theselected account fully healthy.
That made later requests eligible to select the same eventless account again,
turning a single missing-created timeout into repeated
upstream_request_timeoutfailures. The request itself is still failed closedwithout replaying or moving it to another account, but the selected account now
records the normal transient health failure so subsequent selection can avoid
the unhealthy route.
Changes
missing-
response.createddeadline expires.submission of the timed-out request on another account.
recovery behavior.
_handle_stream_errorfor a realAccount.Tests
uv run pytest -q tests/unit/test_proxy_http_bridge.pyuv run ruff check app/modules/proxy/_service/http_bridge/upstream_events.py tests/unit/test_proxy_http_bridge.pygit diff --checkopenspec validate recover-codex-desktop-idle-bridge --strictFull
openspec validate --specsstill reports existing normative-keywordissues in
api-keysandconversations-api, outside this change.