feat(proxy): report websocket cleanup phase - #1726
Open
kevinsslin wants to merge 2 commits into
Open
Conversation
kevinsslin
marked this pull request as ready for review
August 14, 2026 04:10
kevinsslin
added a commit
to kevinsslin/codex-lb
that referenced
this pull request
Aug 14, 2026
Integrates the reviewed transport reliability fixes from upstream PRs Soju06#1723, Soju06#1726, and Soju06#1736 into the production fork main after combined local validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds low-cardinality phase attribution to the existing WebSocket scope cleanup timeout warning, so operators can tell whether cleanup is blocked in upstream close, reader observation, request finalization, or lease release without enabling noisy per-step logs.
Type of change
fix:— bug fix (no behavior change beyond the bug)feat:— new user-facing feature or capabilityrefactor:— internal refactor (no behavior change, no API change)docs:— documentation onlychore:/ci:/build:— tooling, CI, packagingtest:— test-only changeLinked issue: Closes #1724
OpenSpec
Change directory:
openspec/changes/attribute-websocket-scope-cleanup-phase/Changes
cleanup_phase=<phase>to the existing cleanup-budget warning.pending_requestswhile remaining background-drain-owned.Simplicity
.env.example, dashboard navigation, or default changes.Test plan
The full
local-ciparity hook reached the PostgreSQL target after its frontend/backend gates, then failed during migration-test collection because no PostgreSQL server was listening on local127.0.0.1:5432. This PR changes no DB or migration files; the required GitHub PostgreSQL jobs remain authoritative for that environment-backed gate.Screenshots / output
Before:
After:
The phase is a fixed low-cardinality value and does not contain request IDs, account IDs, payloads, credentials, or exception content.
Checklist