fix(proxy): keep file-pin owner on soft 1011 reconnect by mastertyko · Pull Request #1761 · Soju06/codex-lb

mastertyko · 2026-08-14T18:45:15Z

Summary

A live input_file.file_id pin is hard ownership. Soft HTTP-bridge reconnect after upstream 1011 treated that owner as skippable prompt-cache locality, so submit-on-closed recovery could send the file to another account.

Type of change

fix: — bug fix (no behavior change beyond the bug)

Linked issue: none — discovered on current main; adjacent to #1521 (cross-replica pin persistence), not a duplicate.

OpenSpec

This PR includes / updates an OpenSpec change
This PR touches a codex-faithful path (image pipeline, request/response
shape, SSE framing, OAuth flow) and preserves upstream-equivalent behavior

Change directory: openspec/changes/keep-file-pin-owner-on-soft-1011-reconnect/

Changes

_reconnect_http_bridge_session treats file_required_preferred_account as a required owner (falls back to the current session account if preferred_account_id is missing).
_retry_http_bridge_request_on_fresh_upstream now passes require_preferred_account when a live file pin is present.
Soft 1011 reconnects without a file pin still skip the closed account.
Unit coverage for keep-owner, skip-without-pin, and the fresh-upstream call shape.

Test plan

uv run pytest \
  tests/unit/test_proxy_http_bridge.py::test_reconnect_http_bridge_session_preserves_hard_account_after_1011 \
  tests/unit/test_proxy_http_bridge.py::test_reconnect_http_bridge_session_keeps_soft_file_pin_owner_after_1011 \
  tests/unit/test_proxy_http_bridge.py::test_reconnect_http_bridge_session_skips_soft_account_after_1011_without_file_pin \
  tests/unit/test_proxy_http_bridge.py::test_retry_http_bridge_request_on_fresh_upstream_reconnects_without_resending_previous_response_id \
  tests/unit/test_proxy_http_bridge.py::test_retry_http_bridge_request_on_fresh_upstream_requires_file_pin_owner \
  tests/unit/test_proxy_http_bridge.py::test_reconnect_http_bridge_session_fails_closed_when_bound_account_is_excluded \
  tests/unit/test_proxy_http_bridge.py::test_reconnect_http_bridge_session_ignores_stale_preferred_account_after_1011 \
  -q
# 7 passed
openspec validate keep-file-pin-owner-on-soft-1011-reconnect --strict
# valid

Full local CI not run. GitHub required CI is the integration gate.

Related work

fix(proxy): persist file ownership across replicas #1521 (open, persist file pins across replicas) — different invariant; this PR only closes same-process reconnect.
fix(proxy): fail over stuck HTTP bridge owner requests to a fresh account #1401 (merged) — 1011 failover for movable requests; file-pinned requests must not take that skip path.
fix(proxy): keep hard continuity owners ahead of affinity #1732 (open) — hard continuity vs affinity; not this reconnect hole.

Checklist

Title is in Conventional Commits format (<type>(<scope>)?: <subject>).
Added or updated tests covering the change.
Ran the focused reconnect unit tests and strict OpenSpec validation for this change.
CHANGELOG is not edited by hand (release-please handles it).
No new setting, README section, or dashboard nav item.

A live input_file pin is hard ownership. Soft HTTP-bridge reconnect after upstream 1011 was treating that owner as skippable prompt-cache locality.

mastertyko · 2026-08-14T18:45:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 117a475aa2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Move reconnect owner resolution out of mixin.py so the architecture check stays green, and update the remaining fresh-upstream call-shape assertion.

mastertyko · 2026-08-14T19:25:34Z

@codex review

chatgpt-codex-connector · 2026-08-14T19:29:07Z

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 3a7b04f1e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Fresh-upstream retry swallowed the required-owner envelope and the submit-on-closed path replaced it with generic upstream_unavailable.

mastertyko · 2026-08-14T19:56:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6234fb98fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Terminal reconnect selection failures (no_accounts, preferred miss, local cap) were still emitted as generic selection errors even when a live file pin made the owner required.

mastertyko · 2026-08-14T21:27:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65a634d888

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Precreated retry already fail-closes when the required file owner cannot be selected; the envelope is now previous_response_owner_unavailable.

mastertyko · 2026-08-14T22:36:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6230c97b9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Selecting the file-pin owner and then failing to open its replacement socket still collapsed submit-on-closed into generic upstream_unavailable.

mastertyko · 2026-08-14T22:56:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9eaac241bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

A budget-expired ClientError or TimeoutError while opening the file-pin owner's replacement socket still collapsed submit-on-closed to a generic upstream_unavailable envelope.

mastertyko · 2026-08-14T23:07:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bca9ba7f22

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

A budget-expired RefreshError for the file-pin owner still collapsed submit-on-closed into generic upstream_unavailable.

mastertyko · 2026-08-14T23:15:50Z

@codex review

chatgpt-codex-connector · 2026-08-14T23:19:40Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 9e85128add

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fix(proxy): keep file-pin owner on soft 1011 reconnect

117a475

A live input_file pin is hard ownership. Soft HTTP-bridge reconnect after upstream 1011 was treating that owner as skippable prompt-cache locality.

chatgpt-codex-connector Bot reviewed Aug 14, 2026

View reviewed changes

Comment thread app/modules/proxy/_service/http_bridge/request_submit.py

Komzpa added the 🤖 codex: needs work [@codex review] raised an issue label Aug 14, 2026

fix(proxy): stay under http-bridge mixin line ratchet

3a7b04f

Move reconnect owner resolution out of mixin.py so the architecture check stays green, and update the remaining fresh-upstream call-shape assertion.

fix(proxy): surface file-pin owner-unavailable on soft reconnect

6234fb9

Fresh-upstream retry swallowed the required-owner envelope and the submit-on-closed path replaced it with generic upstream_unavailable.

chatgpt-codex-connector Bot reviewed Aug 14, 2026

View reviewed changes

Comment thread app/modules/proxy/_service/http_bridge/request_submit.py

fix(proxy): map required-owner reconnect miss to owner-unavailable

65a634d

Terminal reconnect selection failures (no_accounts, preferred miss, local cap) were still emitted as generic selection errors even when a live file pin made the owner required.

Komzpa removed the 🤖 codex: needs work [@codex review] raised an issue label Aug 14, 2026

chatgpt-codex-connector Bot reviewed Aug 14, 2026

View reviewed changes

Comment thread app/modules/proxy/_service/http_bridge/request_submit.py

Komzpa added the 🤖 codex: needs work [@codex review] raised an issue label Aug 14, 2026

test(proxy): expect owner-unavailable on file-owner reconnect miss

6230c97

Precreated retry already fail-closes when the required file owner cannot be selected; the envelope is now previous_response_owner_unavailable.

chatgpt-codex-connector Bot reviewed Aug 14, 2026

View reviewed changes

Comment thread tests/unit/test_proxy_http_bridge.py

fix(proxy): map required-owner connect miss to owner-unavailable

9eaac24

Selecting the file-pin owner and then failing to open its replacement socket still collapsed submit-on-closed into generic upstream_unavailable.

chatgpt-codex-connector Bot reviewed Aug 14, 2026

View reviewed changes

Comment thread app/modules/proxy/_service/http_bridge/mixin.py

fix(proxy): map required-owner transport miss to owner-unavailable

bca9ba7

A budget-expired ClientError or TimeoutError while opening the file-pin owner's replacement socket still collapsed submit-on-closed to a generic upstream_unavailable envelope.

chatgpt-codex-connector Bot reviewed Aug 14, 2026

View reviewed changes

Comment thread app/modules/proxy/_service/http_bridge/mixin.py

fix(proxy): map required-owner refresh miss to owner-unavailable

9e85128

A budget-expired RefreshError for the file-pin owner still collapsed submit-on-closed into generic upstream_unavailable.

Komzpa added 🤖 codex: ok [@codex review] says no issues found. and removed 🤖 codex: needs work [@codex review] raised an issue labels Aug 15, 2026

Komzpa merged commit f694c44 into Soju06:main Aug 15, 2026
34 of 35 checks passed

This was referenced Aug 15, 2026

chore: release v1.24.0-beta.1 #1704

Open

chore(main): release 1.24.0 #1692

Open

mastertyko mentioned this pull request Aug 15, 2026

fix(proxy): do not rewrite thread locality for a file-pin owner #1765

Open

6 tasks

Conversation

mastertyko commented Aug 14, 2026

Summary

Type of change

OpenSpec

Changes

Test plan

Related work

Checklist

Uh oh!

mastertyko commented Aug 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mastertyko commented Aug 14, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 14, 2026

Uh oh!

mastertyko commented Aug 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mastertyko commented Aug 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mastertyko commented Aug 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mastertyko commented Aug 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mastertyko commented Aug 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mastertyko commented Aug 14, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants