fix(db): merge identity-index and quota-warmup migration heads - #1762
fix(db): merge identity-index and quota-warmup migration heads#1762Komzpa wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb95d1f024
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "20260814_000000_add_accounts_chatgpt_identity_index", | ||
| "20260806_140000_merge_quota_warmup_claim_expiry_head", |
There was a problem hiding this comment.
Include both parent revisions before merging the heads
In the reviewed commit, neither referenced revision exists under app/db/alembic/versions (a repo-wide search finds these IDs only in this new file). Alembic therefore cannot resolve this revision's ancestry when startup or migration-policy checks call ScriptDirectory.get_heads()/walk_revisions(), so deployments of this tree fail before any migration can run. Land both parent revision files in the same reachable tree, or defer this merge revision until they are present.
AGENTS.md reference: AGENTS.md:L116-L120
Useful? React with 👍 / 👎.
|
Withdrawn: overlay-local Alembic head convergence is deployment mechanics, not upstream material. The local deploy helper will generate the no-op merge revision inside the assembled stack instead. |
No-op Alembic merge revision converging the #1732 accounts-identity-index head with the #1646 quota-warmup claim-expiry head, so deployments carrying both see one canonical migration head. Same pattern as the earlier #1745 merge-head PR. Standalone CI is expected red until both parent revisions are on main; the revision is inert (empty upgrade/downgrade).