Feat: Add more devnet functions, constants#118
Merged
Conversation
fm2055
reviewed
Aug 22, 2025
Contributor
fm2055
left a comment
fm2055
left a comment
There was a problem hiding this comment.
Thanks @akashrdev
-
Since getPrimaryDomain has been added under devnet, we should probably add the corresponding test under devnet.test.ts as well.
-
Just wondering, are updateRecordV2/deleteRecordV2 needed as well? It might be awkward if users could create records but not update/delete them. (validate/writeRoa might be overkill though for hackathon)
akashrdev
force-pushed
the
feat/add-more-devnet-fx
branch
from
3a9a2d2 to
9f11241
Compare
fm2055
approved these changes
Aug 25, 2025
Contributor
|
akashrdev
force-pushed
the
feat/add-more-devnet-fx
branch
from
ace1b4e to
67f183b
Compare
Contributor
Author
Apologies, missed your comment before I requested a re-review. Those functions have been added along with 'writRoaRecordV2', and 'validateRecordV2Content' as well. The corresponding tests have been added too. |
…corresponding tests
akashrdev
force-pushed
the
feat/add-more-devnet-fx
branch
from
67f183b to
060303f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Primary domain and Records V2 functions to devnet bindings and utils