BUILD-11568 Add config-uv action - #293
Conversation
ross-bragg-sonarsource
left a comment
There was a problem hiding this comment.
lgtm based on the results of https://github.com/SonarSource/sonarsource-infra-log-archive/pull/124
There was a problem hiding this comment.
Pull request overview
Adds a new config-uv composite action to configure uv for Repox/Artifactory (via JFrog CLI), including uv index credential injection and dependency caching, plus associated docs and ShellSpec coverage.
Changes:
- Introduce
config-uvcomposite action (config-uv/action.yml) and its supporting shell script (config-uv/uv_config.sh) + local mise config. - Add ShellSpec tests for
config-uvand include it in kcov coverage patterns. - Document
config-uvusage/inputs/outputs inREADME.md.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
config-uv/action.yml |
New composite action wiring (Vault auth, caching, mise setup, uv config script execution). |
config-uv/uv_config.sh |
Shell script to configure jf config + export UV_INDEX_* env vars. |
config-uv/mise.local.toml |
Local mise tool/env config used during action execution. |
spec/config-uv_spec.sh |
ShellSpec coverage for uv_config.sh behaviors. |
README.md |
Adds config-uv documentation section and TOC entry. |
.shellspec |
Includes config-uv in coverage include-patterns. |
.github/workflows/test-update-release-channel.yml |
Adjusts permissions and adds an extra action invocation in the test workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e46040b to
a793c12
Compare
68f61f5 to
0c0757c
Compare
Add a config-uv composite action that fetches Artifactory reader credentials from Vault and exposes UV_INDEX_* authentication for the Repox PyPI index. Configure jf for Repox, cache uv dependencies under .cache/uv, and include shellspec coverage plus README documentation.
0c0757c to
507bd0f
Compare
|
Code Review 👍 Approved with suggestions 5 resolved / 6 findingsImplements the 💡 Security: Artifactory token persisted to GITHUB_ENV for whole job📄 config-uv/uv_config.sh:26-29 📄 config-uv/action.yml:102-111 Unlike ✅ 5 resolved✅ Bug: mise backup/restore use mismatched working directories
✅ Edge Case: Caching silently disabled for any disable-caching value except 'false'
✅ Bug: mise restore not run when uv_config.sh fails or action errors
✅ Security: Access token passed as CLI arg and stored in persistent jf config
✅ Edge Case: Degenerate uv-index-name yields malformed env var names
🤖 Prompt for agentsOptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |



Summary
config-uvcomposite action to fetch Artifactory reader credentials from Vault and exposeUV_INDEX_*authentication for the Repox PyPI index.cache/uvkeyed onuv.lockandpyproject.tomlTest plan
shellspec spec/config-uv_spec.shpasses locally (5 examples)