BUILD-11669 Fix config-npm in test-urc-happy-path - #312
Conversation
de07751 to
4d558d0
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates CI workflow setup to prevent NPM-related TLS failures on self-hosted runners when mise installs tools from mise.toml, by ensuring NPM is configured beforehand. It also includes a temporary Renovate configuration change to test behavior against an unmerged renovate-config branch.
Changes:
- Add
id-token: writeand run./config-npmbeforejdx/mise-actionin thetest-urc-happy-pathworkflow job. - Update
.github/renovate.jsonto extend a branch-basedSonarSource/renovate-configpreset (noted as temporary/WIP in the PR description).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/test-update-release-channel.yml |
Grants OIDC permission and configures NPM before running mise in the happy-path job. |
.github/renovate.json |
Points Renovate at an additional preset from a branch (temporary/WIP). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4d558d0 to
7d3b292
Compare
npm:markdownlint-cli install was failing with UNABLE_TO_VERIFY_LEAF_SIGNATURE because config-npm (which sets up the CA cert and Repox registry) was not called before jdx/mise-action reads the root mise.toml. Also add id-token: write permission required by config-npm to authenticate with Vault.
7d3b292 to
0951023
Compare
|
Code Review ✅ ApprovedAdds ./config-npm and id-token permissions before mise-action to resolve npm signature verification errors. Remember to revert the temporary renovate.json change before merging. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |



Summary
./config-npm(+id-token: write) beforejdx/mise-actionin thetest-urc-happy-pathjob — the rootmise.tomlincludesnpm:markdownlint-cliwhich causesUNABLE_TO_VERIFY_LEAF_SIGNATUREon self-hosted runners without CA configRelated