Skip to content

BUILD-11669 Fix config-npm in test-urc-happy-path - #312

Merged
julien-carsique-sonarsource merged 1 commit into
masterfrom
fix/BUILD-11669-config-npm-test
Jun 23, 2026
Merged

BUILD-11669 Fix config-npm in test-urc-happy-path#312
julien-carsique-sonarsource merged 1 commit into
masterfrom
fix/BUILD-11669-config-npm-test

Conversation

@julien-carsique-sonarsource

@julien-carsique-sonarsource julien-carsique-sonarsource commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add ./config-npm (+ id-token: write) before jdx/mise-action in the test-urc-happy-path job — the root mise.toml includes npm:markdownlint-cli which causes UNABLE_TO_VERIFY_LEAF_SIGNATURE on self-hosted runners without CA config

Related

@julien-carsique-sonarsource
julien-carsique-sonarsource requested a review from a team as a code owner June 19, 2026 14:50
Copilot AI review requested due to automatic review settings June 19, 2026 14:50
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jun 19, 2026

Copy link
Copy Markdown

BUILD-11669

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CI workflow setup to prevent NPM-related TLS failures on self-hosted runners when mise installs tools from mise.toml, by ensuring NPM is configured beforehand. It also includes a temporary Renovate configuration change to test behavior against an unmerged renovate-config branch.

Changes:

  • Add id-token: write and run ./config-npm before jdx/mise-action in the test-urc-happy-path workflow job.
  • Update .github/renovate.json to extend a branch-based SonarSource/renovate-config preset (noted as temporary/WIP in the PR description).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/test-update-release-channel.yml Grants OIDC permission and configures NPM before running mise in the happy-path job.
.github/renovate.json Points Renovate at an additional preset from a branch (temporary/WIP).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/renovate.json Outdated
npm:markdownlint-cli install was failing with UNABLE_TO_VERIFY_LEAF_SIGNATURE
because config-npm (which sets up the CA cert and Repox registry) was not
called before jdx/mise-action reads the root mise.toml.

Also add id-token: write permission required by config-npm to authenticate
with Vault.
@julien-carsique-sonarsource
julien-carsique-sonarsource force-pushed the fix/BUILD-11669-config-npm-test branch from 7d3b292 to 0951023 Compare June 23, 2026 08:10
@sonarqubecloud

Copy link
Copy Markdown

@julien-carsique-sonarsource
julien-carsique-sonarsource merged commit 84ce07c into master Jun 23, 2026
17 checks passed
@julien-carsique-sonarsource
julien-carsique-sonarsource deleted the fix/BUILD-11669-config-npm-test branch June 23, 2026 08:14
@gitar-bot

gitar-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Adds ./config-npm and id-token permissions before mise-action to resolve npm signature verification errors. Remember to revert the temporary renovate.json change before merging.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants