PREQ-7805 Fix config-pip README usage example order - #334
Conversation
The example showed actions/setup-python running before config-pip, which defeats the purpose: setup-python's internal pip upgrade would still hit public pypi.org before pip is routed through Repox. Swap the order so config-pip runs first, matching the fix already applied in sonardata-tools#59 and gh-action_releasability#150.
Code Review ✅ ApprovedReorders the config-pip usage example in the README so that setup-python runs after the configuration step, correctly routing pip through Repox. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
There was a problem hiding this comment.
Pull request overview
Updates the config-pip documentation to ensure the usage example configures pip before actions/setup-python, so setup-python’s internal pip upgrade/install steps can use the configured repository routing (preventing direct access to public PyPI).
Changes:
- Reordered the
### UsageYAML example steps soconfig-pipruns beforeactions/setup-python.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Summary
config-pip### Usageexample in README.md showedactions/setup-pythonrunning beforeconfig-pip. That order defeats the fix's purpose:setup-python's own internalpip install --upgrade pipstep still hits publicpypi.orgdirectly, before pip has been routed through Repox — which is exactly the SSL/PyPI-brownout failure reported in PREQ-7805.config-pipruns first, matching the pattern already fixed inSonarSource/sonardata-tools#59andSonarSource/gh-action_releasability#150.setup-pythonreference in the repo (README, workflows, or other actions' docs) — no other examples needed the same fix.config-pip/action.ymlandget-build-number/action.ymlwere also checked: neither invokespip/pythonthemselves, so reordering is safe.Jira: PREQ-7805
Test plan