Skip to content

Update .gitignore to include Eclipse files, update runners for gha - #120

Merged
jonas-wielage-sonarsource merged 5 commits into
masterfrom
jw/update-eclipse-ignore
Apr 13, 2026
Merged

jonas-wielage-sonarsource merged 5 commits into
masterfrom
jw/update-eclipse-ignore

Conversation

@jonas-wielage-sonarsource

Copy link
Copy Markdown
Contributor

No description provided.

@sonar-review-alpha

sonar-review-alpha Bot commented Apr 13, 2026 •

Copy link
Copy Markdown

Summary

This PR makes two distinct changes:

  1. Adds Eclipse IDE entries to .gitignore: Ignores bin/, .classpath, .project, and .settings files/directories commonly generated by Eclipse.

  2. Updates GitHub workflow runner labels: Changes 4 workflow files (PullRequestClosed.yml, PullRequestCreated.yml, RequestReview.yml, SubmitReview.yml) from sonar-xs to github-ubuntu-latest-s runner.

The PR title only mentions the .gitignore update; the workflow changes appear to be additional, unrelated modifications.

What reviewers should know

Scope mismatch to verify: The PR title describes only the .gitignore change, but workflow runner updates are also included. Confirm whether the workflow changes are intentional or should be split into a separate PR.

Focus areas:

  • .gitignore changes are straightforward additions of standard Eclipse IDE artifacts
  • Workflow runner changes (sonar-xs → github-ubuntu-latest-s) suggest infrastructure migration — verify this aligns with team runner availability and CI/CD requirements
  • Check if the runner change was coordinated with DevOps/infrastructure team, especially if sonar-xs is being deprecated

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@jonas-wielage-sonarsource jonas-wielage-sonarsource changed the title Update .gitignore to include Eclipse files Update .gitignore to include Eclipse files, update runners for gha Apr 13, 2026
@sonarqube-next

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed for 'cloud-native-gradle-modules'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@sonar-review-alpha sonar-review-alpha Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, straightforward PR. The two changes are independent — .gitignore additions for Eclipse IDE artifacts and a consistent runner migration across all four workflows — both are correct and well-scoped.

🗣️ Give feedback

@jonas-wielage-sonarsource
jonas-wielage-sonarsource merged commit 1797ca6 into master Apr 13, 2026
6 of 7 checks passed
@jonas-wielage-sonarsource
jonas-wielage-sonarsource deleted the jw/update-eclipse-ignore branch April 13, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants