You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Update .gitignore to include Eclipse files, update runners for gha - #120
Adds Eclipse IDE entries to .gitignore: Ignores bin/, .classpath, .project, and .settings files/directories commonly generated by Eclipse.
Updates GitHub workflow runner labels: Changes 4 workflow files (PullRequestClosed.yml, PullRequestCreated.yml, RequestReview.yml, SubmitReview.yml) from sonar-xs to github-ubuntu-latest-s runner.
The PR title only mentions the .gitignore update; the workflow changes appear to be additional, unrelated modifications.
What reviewers should know
Scope mismatch to verify: The PR title describes only the .gitignore change, but workflow runner updates are also included. Confirm whether the workflow changes are intentional or should be split into a separate PR.
Focus areas:
.gitignore changes are straightforward additions of standard Eclipse IDE artifacts
Workflow runner changes (sonar-xs → github-ubuntu-latest-s) suggest infrastructure migration — verify this aligns with team runner availability and CI/CD requirements
Check if the runner change was coordinated with DevOps/infrastructure team, especially if sonar-xs is being deprecated
jonas-wielage-sonarsource
changed the title
Update .gitignore to include Eclipse files
Update .gitignore to include Eclipse files, update runners for gha
Apr 13, 2026
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
Clean, straightforward PR. The two changes are independent — .gitignore additions for Eclipse IDE artifacts and a consistent runner migration across all four workflows — both are correct and well-scoped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.