SONARJAVA-5718 Fix fullyQualifiedName() on Union types #5351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Union types in multi-catch blocks now have unique and accurate fully qualified names. Previously, union types (e.g., `MatchException | NumberFormatException` in multi-catch) returned a non-unique FQN of their common supertype (e.g., "java.lang.RuntimeException"), which conflicted with actual RuntimeException types. Changes: - Added `isUnionType()` and `getUnionTypes()` methods to the Type API - Introduced union type alternatives tracking in JSema via a new cache - Modified JParser to capture ITypeBinding for each union type alternative - Updated fullyQualifiedName() to return sorted, pipe-separated alternatives (e.g., "java.lang.MatchException | java.lang.NumberFormatException") - Implemented proper union type detection and alternative retrieval in JType - Added default implementations in Symbols for non-union types - Updated tests to verify correct union type handling This enables rules to accurately distinguish between actual exception types and union types in catch clauses. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add comprehensive test coverage for union type implementation with 4 new tests: * Test union types with 3+ alternatives * Verify FQN alphabetical ordering for union types * Test non-union types return false for isUnionType() * Test primitive types are not union types - Reduce cognitive complexity of fullyQualifiedName() method by extracting logic into separate helper methods: * baseQualifiedName() for base type name resolution * buildIntersectionTypeName() for intersection type handling * buildUnionTypeName() for union type handling - Fix visibility of alternativeBindings field from public to package-private in JavaTree.UnionTypeTreeImpl All 91 tests pass successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Contributor
|
This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5718
Union types in multi-catch blocks now have unique and accurate fully qualified names.
Previously, union types (e.g.,
MatchException | NumberFormatExceptionin multi-catch) returned a non-unique FQN of their common supertype (e.g., "java.lang.RuntimeException"), which conflicted with actual RuntimeException types.Changes:
isUnionType()andgetUnionTypes()methods to the Type APIThis enables rules to accurately distinguish between actual exception types and union types in catch clauses.
Part of