PLUGINAPI-42 Replace javax #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacek-poreda-sonarsource
requested review from
damien-urruty-sonarsource,
dbmeneses,
marcin-majewski-sonarsource and
johann-beleites-sonarsource
as code owners
|
@dbmeneses You can have a look again, I think we have addressed all things you have mentioned |
|
SonarQube Quality Gate
|
dbmeneses
approved these changes
Apr 19, 2023
|
@dbmeneses: would you mind having a look at the changes I made to changelog in this commit. Many thanks! |
Looks good to me, thanks! |
- Use new types for identity providers, deprecate javax methods - Introduce HttpFilter class and deprecate ServletFilter which is using javax.servlet.* - Add new methods required by filters in SonarQube - Deprecate javax.servlet usage in org.sonar.api.security package Co-authored-by: Eric Giffon <[email protected]> Co-authored-by: Alain Kermis <[email protected]> Co-authored-by: Antoine Vinot <[email protected]> Co-authored-by: Jacek Poreda <[email protected]>
jacek-poreda-sonarsource
force-pushed
the
task/PLUGINAPI-42-replace-javax
branch
from
f9a55eb to
dcf517d
Compare
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally closed PR, so here is reference to it: #92