Skip to content

RUST-135 Revert "Pin dependencies (#221)"#223

Merged
romainbrenguier merged 1 commit into
masterfrom
romain/revert-pin
Apr 24, 2026
Merged

RUST-135 Revert "Pin dependencies (#221)"#223
romainbrenguier merged 1 commit into
masterfrom
romain/revert-pin

Conversation

@romainbrenguier

Copy link
Copy Markdown
Contributor

This reverts commit 889cb35.

As these are internal dependencies, they don't bring security risks and not pinning as the advantage of automatically using new versions.

@romainbrenguier romainbrenguier requested a review from a team as a code owner April 24, 2026 13:37
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Revert "Pin dependencies (#221)" RUST-135 Revert "Pin dependencies (#221)" Apr 24, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

RUST-135

@sonar-review-alpha

sonar-review-alpha Bot commented Apr 24, 2026

Copy link
Copy Markdown

Summary

This PR reverts dependency pinning in GitHub Actions workflows, moving from exact version pins to floating major version tags. Changes affect 15+ workflow files and involve internal SonarSource dependencies:

  • vault-action-wrapper: 3.4.0v3
  • ci-github-actions/*: 1.3.34v1
  • gh-action_release: 6.8.0v6
  • Similar updates to other SonarSource actions

This enables automatic updates to minor and patch versions rather than requiring explicit upgrades in future commits.

What reviewers should know

Scope: All changes are confined to .github/workflows/ files—no code changes.

Key trade-off: Reverting from pinned versions means workflows will automatically pick up new minor/patch releases from these internal SonarSource dependencies, but at the cost of less reproducible builds. The previous commit (#221) pinned for reproducibility; this revert prioritizes staying current with fixes and improvements.

What to check:

  • Whether this aligns with the team's dependency strategy (auto-update vs locked versions)
  • Any concerns about internal actions releasing breaking changes on major version boundaries (unlikely for internal tools, but worth noting)

Context: These are internal SonarSource dependencies with no external security implications, making version floats lower risk than external dependencies.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@sonar-review-alpha sonar-review-alpha Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, consistent change across all workflow files. Notably, external/third-party actions (actions/checkout, jdx/mise-action) remain SHA-pinned throughout — only internal SonarSource actions are unpinned, which is the right split from a supply-chain security perspective.

🗣️ Give feedback

@sonarqube-next

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed for 'sonar-rust'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@ghislainpiot ghislainpiot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romainbrenguier romainbrenguier merged commit 025558c into master Apr 24, 2026
16 checks passed
@romainbrenguier romainbrenguier deleted the romain/revert-pin branch April 24, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants