Skip to content

RUST-140 Bump RUST_VERSION to 1.95.0 in build workflow#231

Merged
saberduck merged 1 commit into
masterfrom
tibor/update-rust-1.95
Apr 30, 2026
Merged

RUST-140 Bump RUST_VERSION to 1.95.0 in build workflow#231
saberduck merged 1 commit into
masterfrom
tibor/update-rust-1.95

Conversation

@saberduck

Copy link
Copy Markdown
Contributor
  • Bumps RUST_VERSION env var in .github/workflows/build.yml from 1.91.1 to 1.95.0 (current stable, released 2026-04-14).
  • Aligns CI toolchain with Clippy metadata already updated for 1.95.0 in Update Clippy metadata for Rust 1.95.0 #220.

@saberduck saberduck requested a review from a team as a code owner April 29, 2026 12:09
@sonar-review-alpha

sonar-review-alpha Bot commented Apr 29, 2026

Copy link
Copy Markdown

Summary

Updates the Rust toolchain version used in CI from 1.91.1 to 1.95.0. This is a single-line change to the workflow environment variable, making the CI toolchain consistent with Clippy metadata updates already made in #220.

What reviewers should know

Scope: One line changed in .github/workflows/build.yml. This is a low-risk version bump with no behavioral changes to the workflow itself.

What to verify: Check that CI jobs continue to pass with Rust 1.95.0. Since this version is stable and the change is purely a toolchain update, there should be no unexpected breakages unless recent Rust versions introduce new lints or behavior changes for this codebase.

Context: This aligns a previous Clippy update (#220), so the build metadata should now be consistent across the repository.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Bump RUST_VERSION to 1.95.0 in build workflow RUST-140 Bump RUST_VERSION to 1.95.0 in build workflow Apr 29, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

RUST-140

@sonar-review-alpha sonar-review-alpha Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, minimal change. One missed location warrants attention before merge, and there's a pre-existing issue in ShadowScans.yml that's now more visible given the version gap.

Missed update — bump-version.yml: Line 29 in .github/workflows/bump-version.yml has an inline mise.toml snippet that still pins rust = "1.91.1". This version is used when cargo generate-lockfile runs during version bumps. It should be updated to 1.95.0 to stay in sync. The git restore on line 56 of that workflow restores the repo's mise.toml (which doesn't pin Rust at all), so this inline override is the only place this version appears outside build.yml.

Pre-existing — ShadowScans.yml: That workflow references ${{ env.RUST_VERSION }} at line 30 but defines no workflow-level env: block, so the variable expands to an empty string and rustup default will fail. This predates this PR but is now a 4-version gap behind. Worth fixing alongside or in a follow-up.

🗣️ Give feedback

@sonarqube-next

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed for 'sonar-rust'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@sebastien-marichal sebastien-marichal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread .github/workflows/build.yml
@saberduck saberduck merged commit 38b0320 into master Apr 30, 2026
17 checks passed
@saberduck saberduck deleted the tibor/update-rust-1.95 branch April 30, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants