Skip to content

RUST-142 update gh-action_release to v7#233

Merged
erwan-serandour merged 1 commit into
masterfrom
update-release-action
May 19, 2026
Merged

RUST-142 update gh-action_release to v7#233
erwan-serandour merged 1 commit into
masterfrom
update-release-action

Conversation

@erwan-serandour

Copy link
Copy Markdown
Contributor

No description provided.

@erwan-serandour erwan-serandour requested a review from a team as a code owner May 12, 2026 09:48
@erwan-serandour erwan-serandour marked this pull request as draft May 12, 2026 09:48
@sonar-review-alpha

sonar-review-alpha Bot commented May 12, 2026

Copy link
Copy Markdown

Summary

Updates the gh-action_release action from v6 to v7 and changes the release workflow from automatic to manual-only.

Key changes:

  • Removed the automatic on: release: types: [published] trigger — releases no longer happen automatically when a GitHub release is created
  • Kept workflow_dispatch (manual trigger) but simplified inputs by removing the releaseId parameter
  • Simplified the version input description and removed fallback logic that relied on release event data
  • Updated the action reference from v6 to v7

Impact: This workflow is now entirely manual — releases must be triggered via the Actions tab rather than automatically on release publication.

What reviewers should know

Start here: Review the removed release trigger first to understand the shift from event-driven to manual releases. Then check the input changes (especially the removal of releaseId and the new version format requirement of "full version including build number").

Non-obvious point: The v7 action appears to have a simplified API that no longer requires a separate release ID, and the workflow now depends entirely on manual execution rather than GitHub's release event. Verify with your release process documentation that manual-only releases are the intended new behavior.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title update gh-action_release to v7 RUST-142 update gh-action_release to v7 May 12, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

RUST-142

sonar-review-alpha[bot]

This comment was marked as outdated.

@sonarqube-next

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed for 'sonar-rust'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@erwan-serandour erwan-serandour marked this pull request as ready for review May 12, 2026 14:12
@erwan-serandour erwan-serandour marked this pull request as draft May 12, 2026 14:13
sonar-review-alpha[bot]

This comment was marked as outdated.

@saberduck

Copy link
Copy Markdown
Contributor

@erwan-serandour is this ready?

@erwan-serandour erwan-serandour marked this pull request as ready for review May 19, 2026 08:32
@erwan-serandour erwan-serandour merged commit c0f9d29 into master May 19, 2026
36 of 37 checks passed
@erwan-serandour erwan-serandour deleted the update-release-action branch May 19, 2026 08:32

@sonar-review-alpha sonar-review-alpha Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, focused change — but there's one important question to resolve before approving: the removal of the automatic release: types: [published] trigger means the release pipeline is no longer end-to-end automated. Previously, automated-release.yml would create a GitHub release and that publication event would automatically kick off release.yml. Now someone must manually navigate to the Actions tab and trigger release.yml after the automated release completes. If this is intentional (e.g., v7 of gh-action_release is designed to be triggered differently, or the team wants an explicit human gate), it's fine — but it should be confirmed, and the team's runbook / release documentation should be updated to reflect the new manual step.

🗣️ Give feedback

Comment on lines 3 to 6
on:
release:
types:
- published
workflow_dispatch:
inputs:
version:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the release: types: [published] trigger converts the release pipeline from fully automated to semi-manual. Previously, automated-release.yml created a GitHub release → that publication event fired this workflow automatically. Now a human must go to the Actions tab and run this workflow after the automated release completes.

Before merging, please confirm:

  • Is this intentional? (e.g., v7 of gh-action_release provides its own trigger mechanism, or the team wants an explicit gate?)
  • Has the release runbook / CONTRIBUTING docs been updated to document the new manual step?
  • Are there any internal automation tools (e.g. Jira release automations, internal bots) that relied on this workflow firing automatically on release publication that would now silently break?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants