Skip to content

SCANPY-251 Move ownership to CI Experience squad#320

Merged
Seppli11 merged 2 commits into
masterfrom
sz/update-code-owners
Jun 16, 2026
Merged

SCANPY-251 Move ownership to CI Experience squad#320
Seppli11 merged 2 commits into
masterfrom
sz/update-code-owners

Conversation

@Seppli11

@Seppli11 Seppli11 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary by Gitar

  • Codeowners update:
    • Changed ownership of .github/CODEOWNERS from @SonarSource/quality-data-ml-squad to @SonarSource/code-quality-ci-experience-squad.
  • GHA Migration:
    • Migrated SlackNotify.yml to use workflow_run triggers and updated the Slack channel to ops-ci-experience.
    • Updated MacOsNightly.yml to route Slack notifications to ops-ci-experience and corrected the actions/checkout commit hash.

This will update automatically on new commits.

@Seppli11 Seppli11 requested a review from a team June 16, 2026 07:08
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Update Codeowner after code quality re-org SCANPY-251 Update Codeowner after code quality re-org Jun 16, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jun 16, 2026

Copy link
Copy Markdown

SCANPY-251

@guillaume-dequenne guillaume-dequenne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Seppli11 Seppli11 force-pushed the sz/update-code-owners branch from 59ed11c to c621899 Compare June 16, 2026 08:28
@Seppli11 Seppli11 force-pushed the sz/update-code-owners branch from c621899 to b081b89 Compare June 16, 2026 08:29
@Seppli11 Seppli11 changed the title SCANPY-251 Update Codeowner after code quality re-org SCANPY-251 Move ownership to CI Experience squad Jun 16, 2026
Comment thread .github/workflows/SlackNotify.yml
Comment thread .github/workflows/SlackNotify.yml Outdated
@Seppli11 Seppli11 force-pushed the sz/update-code-owners branch from b081b89 to db59e13 Compare June 16, 2026 08:34
@Seppli11 Seppli11 force-pushed the sz/update-code-owners branch from db59e13 to 80d201e Compare June 16, 2026 08:51
@Seppli11 Seppli11 deployed to sca-checking June 16, 2026 08:51 — with GitHub Actions Active
@sonarqube-next

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed for 'Python Scanner'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Seppli11 Seppli11 merged commit b599e83 into master Jun 16, 2026
19 checks passed
@Seppli11 Seppli11 deleted the sz/update-code-owners branch June 16, 2026 08:55
@gitar-bot

gitar-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 2 resolved / 2 findings

Updates CODEOWNERS to reflect the shift to the CI Experience squad and migrates Slack notifications to the appropriate ops channel, resolving issues with duplicate alerts and branch filtering.

✅ 2 resolved
Quality: Duplicate Slack alerts for macOS Nightly Build failures

📄 .github/workflows/SlackNotify.yml:4-18 📄 .github/workflows/MacOsNightly.yml:109-119
SlackNotify.yml now triggers on workflow_run completion (conclusion == failure) for the workflow named "macOS Nightly Build". However, MacOsNightly.yml still contains its own "Send Slack notification" step (lines 109-119) that fires to the same ops-ci-experience channel on failure. As a result, a failed macOS nightly run will send two near-identical Slack messages: one from the workflow's internal step and one from the centralized SlackNotify workflow. Consider removing the inline notification step from MacOsNightly.yml (and any other listed workflow with its own failure notifier) now that SlackNotify centralizes failure alerts, or excluding it from SlackNotify's workflow_run list.

Edge Case: sonar-release failures may not match the branches filter

📄 .github/workflows/SlackNotify.yml:4-17
The workflow_run trigger restricts notifications to branches main, master, branch-*, and dogfood-*. The sonar-release workflow is triggered when publishing a GitHub release, so its head_branch is typically the release tag rather than one of these branch names. If the release run's head branch does not match the filter, SlackNotify will silently skip notifying on a failed release — arguably the most important case to alert on. Verify that github.event.workflow_run.head_branch for release runs matches the configured branch patterns, or relax/adjust the filter for the release workflow.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants