Skip to content

Resolve 5 SonarQube issues across C# and Python code #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolve 5 SonarQube issues across C# and Python code #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions sonar-scanner-dotnet/CSharpProject/SomeConsoleApplication/Program.cs
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,11 @@
using System;
namespace SomeConsoleApplication
{
public class Program
public static class Program
{
static void Main(string[] args)
{
var iAmTrue = true;
if (iAmTrue)
{
Console.WriteLine("true");
}
else
{
Console.WriteLine("false");
}
Console.WriteLine("true");

Console.ReadKey();
}
Expand Down
2 changes: 1 addition & 1 deletion sonar-scanner/src/python/fortune.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,4 @@ def get(filename):
if len(sys.argv) == 1:
print 'Usage: fortune.py <filename>'
sys.exit()
print get(sys.argv[1])
print(get(sys.argv[1]))
4 changes: 2 additions & 2 deletions sonar-scanner/src/python/letters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def play_once():
# Convert the numeric choice to a letter: 0->a, 1->b, etc.
choice=chr(ord('a')+choice)

#choice=raw_input("What should I choose?") # (for debugging)


# We'll track how many possibilities the user still has available.
# Start with all of the letters.
Expand All @@ -83,7 +83,7 @@ def play_once():
# 'return' statement inside the loop.
while (1):
try:
#print possibilities # (for debugging)


# Get input from the user
query=raw_input('Next? ')
Expand Down